[jira] [Commented] (SOLR-12562) Clean up RealTimeGetComponent.toSolrDoc

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (SOLR-12562) Clean up RealTimeGetComponent.toSolrDoc

Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850498#comment-16850498 ]

David Smiley commented on SOLR-12562:

UpdateLogTest is assuming that the type of certain field values in a SolrDocument retrieved from RTG are a NumericDocValuesField wrapper around an integer, instead of simply being an Integer.  I don't think it matters; semantically it's a number just with a wrapper.

> Clean up RealTimeGetComponent.toSolrDoc
> ---------------------------------------
>                 Key: SOLR-12562
>                 URL: https://issues.apache.org/jira/browse/SOLR-12562
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: master (9.0), 8.2
>         Attachments: SOLR-12562.patch, SOLR-12562.patch, SOLR-12562.patch
> This code looks really redundant so we should remove one. The one in RealTimeGet is the only used locally so my vote is to remove that one.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]