[jira] [Commented] (SOLR-13587) Close BackupRepository after every usage

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-13587) Close BackupRepository after every usage

Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-13587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875878#comment-16875878 ]

Kevin Risden commented on SOLR-13587:
-------------------------------------

And when I say "can't" I mean literally there is no close option on an HDFS filesystem instance. It leaks threads since the filesystem instance starts some thread pools and has no close method to stop them. It would be great if we could actually call close on an HDFS filesystem, but nope.

> Close BackupRepository after every usage
> ----------------------------------------
>
>                 Key: SOLR-13587
>                 URL: https://issues.apache.org/jira/browse/SOLR-13587
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public)
>          Components: Backup/Restore
>    Affects Versions: 8.1
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Major
>         Attachments: SOLR-13587.patch
>
>
> Turns out BackupRepository is created every operation, but never closed. I suppose it leads to necessity to have {{BadHdfsThreadsFilter}} in {{TestHdfsCloudBackupRestore}}. Also, test need to repeat backup/restore operation to make sure that closing hdfs filesystem doesn't break it see SOLR-9961 for the case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]