[jira] [Commented] (SOLR-435) QParser must validate existence/absence of "q" parameter

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-435) QParser must validate existence/absence of "q" parameter

Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239605#comment-13239605 ]

Hoss Man commented on SOLR-435:
-------------------------------

bq. Why not simply apply the SOLR-2001 patch for consistent behavior?

good question ... if you're cool with that then it seems okay to me (although off the top of my head i think when i was looking at trunk one of those 4 "main" parsers still needed "fixed" to return null).

in general my suggestion for 3.6 was largely based on the fact that there was still active discussion about what the best long term behavior was, which might contradict what was discussed in SOLR-2001, so better to play it safe and just clean up the error reporting: "I'd rather leave things the way they are then make a bad decision in a hurry"

if you want to backport SOLR-2001 and sanity check that lucene/dismax/edismax/lucenePlusSort all return null on null/blank query strings i'm +1 to that (that seems consistent with what ryan/male/me were advocating here, so as long as your on board i think we're good)

               

> QParser must validate existence/absence of "q" parameter
> --------------------------------------------------------
>
>                 Key: SOLR-435
>                 URL: https://issues.apache.org/jira/browse/SOLR-435
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: David Smiley
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-435.patch, SOLR-435_3x_consistent_errors.patch, SOLR-435_q_defaults_to_all-docs.patch
>
>
> Each QParser should check if "q" exists or not.  For some it will be required others not.
> currently it throws a null pointer:
> {code}
> java.lang.NullPointerException
> at org.apache.solr.common.util.StrUtils.splitSmart(StrUtils.java:36)
> at org.apache.solr.search.OldLuceneQParser.parse(LuceneQParserPlugin.java:104)
> at org.apache.solr.search.QParser.getQuery(QParser.java:80)
> at org.apache.solr.handler.component.QueryComponent.prepare(QueryComponent.java:67)
> at org.apache.solr.handler.SearchHandler.handleRequestBody(SearchHandler.java:150)
>         ...
> {code}
> see:
> http://www.nabble.com/query-parsing-error-to14124285.html#a14140108

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]