[jira] [Commented] (SOLR-5108) plugin loading should fail if mor then one instance of a singleton plugin is found

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-5108) plugin loading should fail if mor then one instance of a singleton plugin is found

Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745101#comment-13745101 ]

ASF subversion and git services commented on SOLR-5108:
-------------------------------------------------------

Commit 1515859 from [hidden email] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1515859 ]

SOLR-5108: fail plugin info loading if multiple instances exist but only one is expected (merge r1515852)
               

> plugin loading should fail if mor then one instance of a singleton plugin is found
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-5108
>                 URL: https://issues.apache.org/jira/browse/SOLR-5108
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR-5108.patch
>
>
> Continuing from the config parsing/validation work done in SOLR-4953, we should improve SolrConfig so that parsing fails if multiple instances of a "plugin" are found for types of plugins where only one is allowed to be used at a time.
> at the moment, {{SolrConfig.loadPluginInfo}} happily initializes a {{List<PluginInfo>}} for whatever xpath it's given, and then later code can either call {{List<PluginInfo> getPluginInfos(String)}} or {{PluginInfo getPluginInfo(String)}} (the later just being shorthand for getting the first item in the list.
> we could make {{getPluginInfo(String)}} throw an error if the list has multiple items, but i think we should also change the signature of {{loadPluginInfo}} to be explicit about how many instances we expect to find, so we can error earlier, and have a redundant check.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]