[jira] [Commented] (SOLR-5875) QueryComponent.mergeIds() unmarshals all docs' sort field values once per doc instead of once per shard

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-5875) QueryComponent.mergeIds() unmarshals all docs' sort field values once per doc instead of once per shard

Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937946#comment-13937946 ]

Erick Erickson commented on SOLR-5875:
--------------------------------------

Hmmm, is it possible to have the original person who posted the problem give it a test run? For something like this it'd be good to have some proof that if fixes the problem described.

Just a thought.

Erick

> QueryComponent.mergeIds() unmarshals all docs' sort field values once per doc instead of once per shard
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5875
>                 URL: https://issues.apache.org/jira/browse/SOLR-5875
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 4.7
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>            Priority: Critical
>             Fix For: 4.8, 5.0, 4.7.1
>
>         Attachments: SOLR-5875.patch
>
>
> SOLR-5354 added unmarshalling of distributed sort field values in {{QueryComponent.mergeIds()}}, but incorrectly performs this (unmarshalling all docs' sort field values) for every doc, and stores the result with each doc.  This is unnecessary, inefficient, and extremely wasteful of memory.
> In an offline conversation, [~alexey] described the issue to me and located the likely problem, and [~[hidden email]] located the problem code via inspection.
> This bug is very likely the problem described on the solr-user mailing list here: [SolrCloud constantly crashes after upgrading to Solr 4.7|http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201403.mbox/%3c83f549bdf8deecbc7567c324ee0cb91f@...%3e]



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]