[jira] Created: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

Shalin Shekhar Mangar (Jira)
Once RPC.stopClient has been called, RPC can not be used again
--------------------------------------------------------------

                 Key: HADOOP-1299
                 URL: https://issues.apache.org/jira/browse/HADOOP-1299
             Project: Hadoop
          Issue Type: Bug
          Components: ipc
            Reporter: [hidden email]
            Priority: Minor


Calls to RPC.stopClient render RPC subsequently unusable -- at least until a reload of RPC class so static initializer has a chance to run again.

I am trying to write unit tests for a little cluster built atop hadoop RPC class.  Intent is to spin up the little cluster before each test is run.  Post unit test, the cluster is torn down.  Part of the takedown includes invocation of RPC.stopClient to clean up any outstanding connections, etc.

I've found that when the second unit test runs, RPC Client is horked.  The 'running' flag is false so Connections can't work and 'Connection Culler' is not running.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

Shalin Shekhar Mangar (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

[hidden email] updated HADOOP-1299:
--------------------------------------

    Attachment: hadoop1299.patch

Suggested fix (Null out the cached CLIENT on RCP.stopClient invocation).

> Once RPC.stopClient has been called, RPC can not be used again
> --------------------------------------------------------------
>
>                 Key: HADOOP-1299
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1299
>             Project: Hadoop
>          Issue Type: Bug
>          Components: ipc
>            Reporter: [hidden email]
>            Priority: Minor
>         Attachments: hadoop1299.patch
>
>
> Calls to RPC.stopClient render RPC subsequently unusable -- at least until a reload of RPC class so static initializer has a chance to run again.
> I am trying to write unit tests for a little cluster built atop hadoop RPC class.  Intent is to spin up the little cluster before each test is run.  Post unit test, the cluster is torn down.  Part of the takedown includes invocation of RPC.stopClient to clean up any outstanding connections, etc.
> I've found that when the second unit test runs, RPC Client is horked.  The 'running' flag is false so Connections can't work and 'Connection Culler' is not running.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

Shalin Shekhar Mangar (Jira)
In reply to this post by Shalin Shekhar Mangar (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

[hidden email] updated HADOOP-1299:
--------------------------------------

    Status: Patch Available  (was: Open)

Marking patch ready for review

> Once RPC.stopClient has been called, RPC can not be used again
> --------------------------------------------------------------
>
>                 Key: HADOOP-1299
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1299
>             Project: Hadoop
>          Issue Type: Bug
>          Components: ipc
>            Reporter: [hidden email]
>            Priority: Minor
>         Attachments: hadoop1299.patch
>
>
> Calls to RPC.stopClient render RPC subsequently unusable -- at least until a reload of RPC class so static initializer has a chance to run again.
> I am trying to write unit tests for a little cluster built atop hadoop RPC class.  Intent is to spin up the little cluster before each test is run.  Post unit test, the cluster is torn down.  Part of the takedown includes invocation of RPC.stopClient to clean up any outstanding connections, etc.
> I've found that when the second unit test runs, RPC Client is horked.  The 'running' flag is false so Connections can't work and 'Connection Culler' is not running.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

Shalin Shekhar Mangar (Jira)
In reply to this post by Shalin Shekhar Mangar (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492204 ]

Hadoop QA commented on HADOOP-1299:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12356360/hadoop1299.patch applied and successfully tested against trunk revision r532878.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/87/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/87/console

> Once RPC.stopClient has been called, RPC can not be used again
> --------------------------------------------------------------
>
>                 Key: HADOOP-1299
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1299
>             Project: Hadoop
>          Issue Type: Bug
>          Components: ipc
>            Reporter: stack
>            Priority: Minor
>         Attachments: hadoop1299.patch
>
>
> Calls to RPC.stopClient render RPC subsequently unusable -- at least until a reload of RPC class so static initializer has a chance to run again.
> I am trying to write unit tests for a little cluster built atop hadoop RPC class.  Intent is to spin up the little cluster before each test is run.  Post unit test, the cluster is torn down.  Part of the takedown includes invocation of RPC.stopClient to clean up any outstanding connections, etc.
> I've found that when the second unit test runs, RPC Client is horked.  The 'running' flag is false so Connections can't work and 'Connection Culler' is not running.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

Shalin Shekhar Mangar (Jira)
In reply to this post by Shalin Shekhar Mangar (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1299:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.13.0
         Assignee: stack
           Status: Resolved  (was: Patch Available)

I just committed this.  Thanks, Michael!

> Once RPC.stopClient has been called, RPC can not be used again
> --------------------------------------------------------------
>
>                 Key: HADOOP-1299
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1299
>             Project: Hadoop
>          Issue Type: Bug
>          Components: ipc
>            Reporter: stack
>         Assigned To: stack
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: hadoop1299.patch
>
>
> Calls to RPC.stopClient render RPC subsequently unusable -- at least until a reload of RPC class so static initializer has a chance to run again.
> I am trying to write unit tests for a little cluster built atop hadoop RPC class.  Intent is to spin up the little cluster before each test is run.  Post unit test, the cluster is torn down.  Part of the takedown includes invocation of RPC.stopClient to clean up any outstanding connections, etc.
> I've found that when the second unit test runs, RPC Client is horked.  The 'running' flag is false so Connections can't work and 'Connection Culler' is not running.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1299) Once RPC.stopClient has been called, RPC can not be used again

Shalin Shekhar Mangar (Jira)
In reply to this post by Shalin Shekhar Mangar (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492470 ]

Hadoop QA commented on HADOOP-1299:
-----------------------------------

Integrated in Hadoop-Nightly #72 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/72/)

> Once RPC.stopClient has been called, RPC can not be used again
> --------------------------------------------------------------
>
>                 Key: HADOOP-1299
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1299
>             Project: Hadoop
>          Issue Type: Bug
>          Components: ipc
>            Reporter: stack
>         Assigned To: stack
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: hadoop1299.patch
>
>
> Calls to RPC.stopClient render RPC subsequently unusable -- at least until a reload of RPC class so static initializer has a chance to run again.
> I am trying to write unit tests for a little cluster built atop hadoop RPC class.  Intent is to spin up the little cluster before each test is run.  Post unit test, the cluster is torn down.  Part of the takedown includes invocation of RPC.stopClient to clean up any outstanding connections, etc.
> I've found that when the second unit test runs, RPC Client is horked.  The 'running' flag is false so Connections can't work and 'Connection Culler' is not running.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.