[jira] Created: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
-----------------------------------------------------------------------------

                 Key: HADOOP-1408
                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
             Project: Hadoop
          Issue Type: Improvement
          Components: mapred
    Affects Versions: 0.13.0
            Reporter: Owen O'Malley
         Assigned To: Owen O'Malley
             Fix For: 0.14.0
         Attachments: no-jsp-cast-warn.patch

There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1408:
----------------------------------

    Attachment: no-jsp-cast-warn.patch

Creates a class that wraps the generic parameters in a real class that can be checked for at runtime.

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1408:
----------------------------------

    Status: Patch Available  (was: Open)

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498297 ]

Hadoop QA commented on HADOOP-1408:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12357809/no-jsp-cast-warn.patch applied and successfully tested against trunk revision r540973.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/188/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/188/console

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1408:
---------------------------------

    Status: Open  (was: Patch Available)

The new public class needs some javadoc.

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1408:
----------------------------------

    Status: Patch Available  (was: Open)

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: hadoop-1408.patch, no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1408:
----------------------------------

    Attachment: hadoop-1408.patch

Added the relevant javadoc

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: hadoop-1408.patch, no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1408:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.  The javadoc comment you added was an implementation note, of no interest to the end user.  I replaced it with something that describes what the class represents, rather than why it was written.  Javadoc is for users.

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: hadoop-1408.patch, no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498386 ]

Hadoop QA commented on HADOOP-1408:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12358023/hadoop-1408.patch applied and successfully tested against trunk revision r541070.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/193/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/193/console

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: hadoop-1408.patch, no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1408) fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498606 ]

Hadoop QA commented on HADOOP-1408:
-----------------------------------

Integrated in Hadoop-Nightly #99 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/99/)

> fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-1408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1408
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.13.0
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.14.0
>
>         Attachments: hadoop-1408.patch, no-jsp-cast-warn.patch
>
>
> There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.