[jira] Created: (HADOOP-1420) Run findbugs against hbase contrib

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
Run findbugs against hbase contrib
----------------------------------

                 Key: HADOOP-1420
                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
             Project: Hadoop
          Issue Type: Improvement
            Reporter: stack


Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reassigned HADOOP-1420:
-----------------------------

    Assignee: stack

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Attachment: hadoop1420.patch

Patch attached.  Below is commit message.

HADOOP-1420. Fix findbugs 'bad practise', 'dodgy', and 'correctness' bugs.
Removed all but one of the 'performance', and some of the
'multithreaded correctness' (complaints about starting threads
in constructor, notifies with no apparent waiter, and
synchronization that doesn't completely cover member access remain).
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLogKey.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreFile.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/Leases.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreKey.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HTableDescriptor.java
    (equals, hashCode): Added.
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegionServer.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HClient.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLog.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HMemcache.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegiondirReader.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HAbstractScanner.java
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java
    All above had one or more of below applied:
    Use autoboxing of Integer and use Map.Entry rather than
    Map.keySet and then a Map.get(key)  (performance).
    Remove synchronization around Thread.sleep.
    Make inner class w/ no references to hosting class static.
    Make inner class w/ no references to hosting class static.
    Use autoboxing of Integer and use Map.Entry rather than
    Map.keySet and then a Map.get(key)  (performance).
* src/contrib/hbase/src/java/org/apache/hadoop/hbase/HServerAddress.java
    Remove odd wrapping of constructed strings in 'new String'.
    Use Map.Entry rather than Map.keySet and then a Map.get(key)
    (performance).

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Status: Patch Available  (was: Open)

Make patch available for test build

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498024 ]

Hadoop QA commented on HADOOP-1420:
-----------------------------------

-1, build or testing failed

2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12357927/hadoop1420.patch against trunk revision r540737.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/182/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/182/console

Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Attachment: hadoop1420-v2.patch

Version 2 of patch.  Includes purge of mention of HLocking from HMemCache.

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Status: Patch Available  (was: In Progress)

Prompt new test with v2 of patch

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Status: In Progress  (was: Patch Available)

Change state to trigger test build with new patch

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498049 ]

Hadoop QA commented on HADOOP-1420:
-----------------------------------

+0, new Findbugs warnings

http://issues.apache.org/jira/secure/attachment/12357929/hadoop1420-v2.patch
applied and successfully tested against trunk revision r540737,
but there appear to be new Findbugs warnings introduced by this patch.

New Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/183/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/183/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/183/console

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498054 ]

stack commented on HADOOP-1420:
-------------------------------

FYI Nigel Hadoop QA, the FindBugs URL doesn't work.  Is my FindBugs patch failing because it only fixes ~80% of reported FindBugs 'bugs' and not all of them?

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (HADOOP-1420) Run findbugs against hbase contrib

Nigel Daley
No, this seems to be a bug in the patch process scripts...but there's  
not enough output for me to tell what it is.  FWIW, the build doesn't  
run Findbugs on HBase so a committer can safely ignore the +0 comment.


On May 22, 2007, at 4:06 PM, stack (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/HADOOP-1420?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12498054 ]
>
> stack commented on HADOOP-1420:
> -------------------------------
>
> FYI Nigel Hadoop QA, the FindBugs URL doesn't work.  Is my FindBugs  
> patch failing because it only fixes ~80% of reported FindBugs  
> 'bugs' and not all of them?
>
>> Run findbugs against hbase contrib
>> ----------------------------------
>>
>>                 Key: HADOOP-1420
>>                 URL: https://issues.apache.org/jira/browse/ 
>> HADOOP-1420
>>             Project: Hadoop
>>          Issue Type: Improvement
>>            Reporter: stack
>>         Assigned To: stack
>>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>>
>>
>> Findbugs is all the rage!  Run it against the hbase contrib.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Status: In Progress  (was: Patch Available)

Nigel Daley notes on the list:

"No, this seems to be a bug in the patch process scripts...but there's not enough output for me to tell what it is.  FWIW, the build doesn't run Findbugs on HBase so a committer can safely ignore the +0 comment. "



> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Attachment: hadoop1420-v3.patch

New version of patch.  Adds changing two Thread.sleeps in HRegionServer around lines 509 and 588 to waits inside sync blocks after a chat with Jim K.

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420-v3.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-1420:
--------------------------

    Status: Patch Available  (was: In Progress)

Volunteering v3 of patch for a test build

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420-v3.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498128 ]

Hadoop QA commented on HADOOP-1420:
-----------------------------------

+0, new Findbugs warnings

http://issues.apache.org/jira/secure/attachment/12357949/hadoop1420-v3.patch
applied and successfully tested against trunk revision r540737,
but there appear to be new Findbugs warnings introduced by this patch.

New Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/185/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/185/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/185/console

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420-v3.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HADOOP-1420:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Michael!

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420-v3.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1420) Run findbugs against hbase contrib

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498604 ]

Hadoop QA commented on HADOOP-1420:
-----------------------------------

Integrated in Hadoop-Nightly #99 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/99/)

> Run findbugs against hbase contrib
> ----------------------------------
>
>                 Key: HADOOP-1420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1420
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: stack
>         Assigned To: stack
>         Attachments: hadoop1420-v2.patch, hadoop1420-v3.patch, hadoop1420.patch
>
>
> Findbugs is all the rage!  Run it against the hbase contrib.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.