[jira] Created: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

Akash (Jira)
Three methods in FSNamesystem should not be synchronized.
---------------------------------------------------------

                 Key: HADOOP-1517
                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
             Project: Hadoop
          Issue Type: Bug
          Components: dfs
    Affects Versions: 0.13.0
            Reporter: Konstantin Shvachko
            Assignee: Konstantin Shvachko
            Priority: Critical
             Fix For: 0.14.0


Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
I missed to remove synchronization modifiers in the following three methods:
startFile()
getAdditionalBlock()
allocateBlock()

Fine grained locking does not work if the first two methods are synchronized.
This is the patch that removes them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

Akash (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-1517:
----------------------------------------

    Attachment: NameSystemSync.patch

> Three methods in FSNamesystem should not be synchronized.
> ---------------------------------------------------------
>
>                 Key: HADOOP-1517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: NameSystemSync.patch
>
>
> Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
> I missed to remove synchronization modifiers in the following three methods:
> startFile()
> getAdditionalBlock()
> allocateBlock()
> Fine grained locking does not work if the first two methods are synchronized.
> This is the patch that removes them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

Akash (Jira)
In reply to this post by Akash (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-1517:
----------------------------------------

    Status: Patch Available  (was: Open)

> Three methods in FSNamesystem should not be synchronized.
> ---------------------------------------------------------
>
>                 Key: HADOOP-1517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: NameSystemSync.patch
>
>
> Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
> I missed to remove synchronization modifiers in the following three methods:
> startFile()
> getAdditionalBlock()
> allocateBlock()
> Fine grained locking does not work if the first two methods are synchronized.
> This is the patch that removes them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

Akash (Jira)
In reply to this post by Akash (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507042 ]

Hadoop QA commented on HADOOP-1517:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12360314/NameSystemSync.patch applied and successfully tested against trunk revision r549605.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/320/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/320/console

> Three methods in FSNamesystem should not be synchronized.
> ---------------------------------------------------------
>
>                 Key: HADOOP-1517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: NameSystemSync.patch
>
>
> Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
> I missed to remove synchronization modifiers in the following three methods:
> startFile()
> getAdditionalBlock()
> allocateBlock()
> Fine grained locking does not work if the first two methods are synchronized.
> This is the patch that removes them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

Akash (Jira)
In reply to this post by Akash (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1517:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.  Thanks, Konstantin!

> Three methods in FSNamesystem should not be synchronized.
> ---------------------------------------------------------
>
>                 Key: HADOOP-1517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: NameSystemSync.patch
>
>
> Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
> I missed to remove synchronization modifiers in the following three methods:
> startFile()
> getAdditionalBlock()
> allocateBlock()
> Fine grained locking does not work if the first two methods are synchronized.
> This is the patch that removes them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (HADOOP-1517) Three methods in FSNamesystem should not be synchronized.

Akash (Jira)
In reply to this post by Akash (Jira)

    [ https://issues.apache.org/jira/browse/HADOOP-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507211 ]

Hudson commented on HADOOP-1517:
--------------------------------

Integrated in Hadoop-Nightly #132 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/132/])

> Three methods in FSNamesystem should not be synchronized.
> ---------------------------------------------------------
>
>                 Key: HADOOP-1517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1517
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: NameSystemSync.patch
>
>
> Joining my UTF8 patch HADOOP-1283 with synchronization changes introduced by HADOOP-1269
> I missed to remove synchronization modifiers in the following three methods:
> startFile()
> getAdditionalBlock()
> allocateBlock()
> Fine grained locking does not work if the first two methods are synchronized.
> This is the patch that removes them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.