[jira] Created: (LUCENE-1064) Make TopDocs constructor public

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-1064) Make TopDocs constructor public

Tim Allison (Jira)
Make TopDocs constructor public
-------------------------------

                 Key: LUCENE-1064
                 URL: https://issues.apache.org/jira/browse/LUCENE-1064
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Search
    Affects Versions: 2.2
         Environment: All
            Reporter: Shai Erera


TopDocs constructor is package visible. This prevents instantiating it from outside this package. For example, I wrote a HitColletor that couldn't extend directly from TopDocCollector. I need to create a new TopDocs instance, however since the c'tor is package visible, I can't do that.
For now, I completely duplicated the code, but I hope you'll fix it soon.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-1064) Make TopDocs constructor public

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-1064:
-------------------------------

    Attachment: TopDocs-patch

The simple patch details

> Make TopDocs constructor public
> -------------------------------
>
>                 Key: LUCENE-1064
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1064
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.2
>         Environment: All
>            Reporter: Shai Erera
>         Attachments: TopDocs-patch
>
>
> TopDocs constructor is package visible. This prevents instantiating it from outside this package. For example, I wrote a HitColletor that couldn't extend directly from TopDocCollector. I need to create a new TopDocs instance, however since the c'tor is package visible, I can't do that.
> For now, I completely duplicated the code, but I hope you'll fix it soon.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (LUCENE-1064) Make TopDocs constructor public

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch reassigned LUCENE-1064:
-------------------------------------

    Assignee: Michael Busch

> Make TopDocs constructor public
> -------------------------------
>
>                 Key: LUCENE-1064
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1064
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.2
>         Environment: All
>            Reporter: Shai Erera
>            Assignee: Michael Busch
>         Attachments: TopDocs-patch
>
>
> TopDocs constructor is package visible. This prevents instantiating it from outside this package. For example, I wrote a HitColletor that couldn't extend directly from TopDocCollector. I need to create a new TopDocs instance, however since the c'tor is package visible, I can't do that.
> For now, I completely duplicated the code, but I hope you'll fix it soon.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-1064) Make TopDocs constructor public

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch resolved LUCENE-1064.
-----------------------------------

    Resolution: Fixed

Committed. Thanks, Shai!

> Make TopDocs constructor public
> -------------------------------
>
>                 Key: LUCENE-1064
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1064
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.2
>         Environment: All
>            Reporter: Shai Erera
>            Assignee: Michael Busch
>         Attachments: TopDocs-patch
>
>
> TopDocs constructor is package visible. This prevents instantiating it from outside this package. For example, I wrote a HitColletor that couldn't extend directly from TopDocCollector. I need to create a new TopDocs instance, however since the c'tor is package visible, I can't do that.
> For now, I completely duplicated the code, but I hope you'll fix it soon.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Resolved: (LUCENE-1064) Make TopDocs constructor public

Shai Erera
Thanks a lot !

On Dec 6, 2007 11:08 AM, Michael Busch (JIRA) <[hidden email]> wrote:

>
>     [
> https://issues.apache.org/jira/browse/LUCENE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Michael Busch resolved LUCENE-1064.
> -----------------------------------
>
>    Resolution: Fixed
>
> Committed. Thanks, Shai!
>
> > Make TopDocs constructor public
> > -------------------------------
> >
> >                 Key: LUCENE-1064
> >                 URL: https://issues.apache.org/jira/browse/LUCENE-1064
> >             Project: Lucene - Java
> >          Issue Type: Improvement
> >          Components: Search
> >    Affects Versions: 2.2
> >         Environment: All
> >            Reporter: Shai Erera
> >            Assignee: Michael Busch
> >         Attachments: TopDocs-patch
> >
> >
> > TopDocs constructor is package visible. This prevents instantiating it
> from outside this package. For example, I wrote a HitColletor that couldn't
> extend directly from TopDocCollector. I need to create a new TopDocs
> instance, however since the c'tor is package visible, I can't do that.
> > For now, I completely duplicated the code, but I hope you'll fix it
> soon.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Regards,

Shai Erera