[jira] Created: (LUCENE-1164) Improve how ConcurrentMergeScheduler handles too-many-merges case

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-1164) Improve how ConcurrentMergeScheduler handles too-many-merges case

Tim Allison (Jira)
Improve how ConcurrentMergeScheduler handles too-many-merges case
-----------------------------------------------------------------

                 Key: LUCENE-1164
                 URL: https://issues.apache.org/jira/browse/LUCENE-1164
             Project: Lucene - Java
          Issue Type: Bug
          Components: Index
    Affects Versions: 2.3
            Reporter: Michael McCandless
            Assignee: Michael McCandless
            Priority: Minor
             Fix For: 2.4


CMS now lets you set "maxMergeThreads" to control max # simultaneous
merges.

However, when CMS hits that max, it still allows further merges to
run, by running them in the foreground thread.  So if you set this max
to 1, and use 1 thread to add docs, you can get 2 merges running at
once (which I think is broken).

I think, instead, CMS should pause the foreground thread, waiting
until the number of merge threads drops below the limit.  Then, kick
off the backlog merge in a thread and return control back to primary
thread.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-1164) Improve how ConcurrentMergeScheduler handles too-many-merges case

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-1164:
---------------------------------------

    Attachment: LUCENE-1164.patch

Attached patch.  I plan to commit in a day or two...

> Improve how ConcurrentMergeScheduler handles too-many-merges case
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1164
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1164
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.3
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1164.patch
>
>
> CMS now lets you set "maxMergeThreads" to control max # simultaneous
> merges.
> However, when CMS hits that max, it still allows further merges to
> run, by running them in the foreground thread.  So if you set this max
> to 1, and use 1 thread to add docs, you can get 2 merges running at
> once (which I think is broken).
> I think, instead, CMS should pause the foreground thread, waiting
> until the number of merge threads drops below the limit.  Then, kick
> off the backlog merge in a thread and return control back to primary
> thread.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-1164) Improve how ConcurrentMergeScheduler handles too-many-merges case

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1164.
----------------------------------------

    Resolution: Fixed

> Improve how ConcurrentMergeScheduler handles too-many-merges case
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1164
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1164
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.3
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1164.patch
>
>
> CMS now lets you set "maxMergeThreads" to control max # simultaneous
> merges.
> However, when CMS hits that max, it still allows further merges to
> run, by running them in the foreground thread.  So if you set this max
> to 1, and use 1 thread to add docs, you can get 2 merges running at
> once (which I think is broken).
> I think, instead, CMS should pause the foreground thread, waiting
> until the number of merge threads drops below the limit.  Then, kick
> off the backlog merge in a thread and return control back to primary
> thread.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]