[jira] Created: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

Nick Burch (Jira)
SpanScorer does not respect ConstantScoreRangeQuery setting
-----------------------------------------------------------

                 Key: LUCENE-1357
                 URL: https://issues.apache.org/jira/browse/LUCENE-1357
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/highlighter
            Reporter: Mark Miller
            Assignee: Mark Miller
            Priority: Minor
             Fix For: 2.4


ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623820#action_12623820 ]

Mark Miller commented on LUCENE-1357:
-------------------------------------

Well this is annoying - the test for this counted on the setting being on - which was what the bug was - the setting was always on. But the fix is not so simple - the setting actually needs to be set before the constructor. I don't like the lazy load option for a few reasons, and that leaves dropping the setter, getter and adding new constructors (there are already too many), or just making the accessor methods static and docing so that users know to call the setter first and that its a global setting.  I am leaning towards making the methods static and global as the best option with the least amount of changes.

> SpanScorer does not respect ConstantScoreRangeQuery setting
> -----------------------------------------------------------
>
>                 Key: LUCENE-1357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1357
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.4
>
>
> ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629117#action_12629117 ]

Michael McCandless commented on LUCENE-1357:
--------------------------------------------

Mark, do you have a concrete patch for this one?  Should we defer beyond 2.4?

> SpanScorer does not respect ConstantScoreRangeQuery setting
> -----------------------------------------------------------
>
>                 Key: LUCENE-1357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1357
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.4
>
>
> ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629127#action_12629127 ]

Mark Miller commented on LUCENE-1357:
-------------------------------------

Ill put it up today...just wanted to make sure anyone had a chance to complain.

> SpanScorer does not respect ConstantScoreRangeQuery setting
> -----------------------------------------------------------
>
>                 Key: LUCENE-1357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1357
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.4
>
>
> ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated LUCENE-1357:
--------------------------------

    Attachment: LUCENE-1357.patch

> SpanScorer does not respect ConstantScoreRangeQuery setting
> -----------------------------------------------------------
>
>                 Key: LUCENE-1357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1357
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1357.patch
>
>
> ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-1357) SpanScorer does not respect ConstantScoreRangeQuery setting

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller resolved LUCENE-1357.
---------------------------------

    Resolution: Fixed

> SpanScorer does not respect ConstantScoreRangeQuery setting
> -----------------------------------------------------------
>
>                 Key: LUCENE-1357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1357
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1357.patch
>
>
> ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]