[jira] Created: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
BooleanQuery.hashCode and equals ignore isCoordDisabled
-------------------------------------------------------

                 Key: LUCENE-2092
                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
             Project: Lucene - Java
          Issue Type: Bug
          Components: Query/Scoring
    Affects Versions: 2.9.1, 2.9, 2.4.1, 2.4, 2.3.2, 2.3.1, 2.3, 2.2, 2.1, 2.0.0, 1.9
            Reporter: Hoss Man


BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.

bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781679#action_12781679 ]

Michael McCandless commented on LUCENE-2092:
--------------------------------------------

This is quite nasty.  Uwe, should we re-spin 3.0 for it?  Or for 3.0.1?

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-2092:
------------------------------------------

    Assignee: Michael McCandless

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2092:
---------------------------------------

    Attachment: LUCENE-2092.patch

Attached patch... the fix caused TestWildcard.testEmptyTerm to fail, so I fixed that too, and on back-compat branch.

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781706#action_12781706 ]

Michael McCandless commented on LUCENE-2092:
--------------------------------------------

Fixed on trunk... I'll backport to 3.0 once Uwe opens it up...

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781716#action_12781716 ]

Erick Erickson commented on LUCENE-2092:
----------------------------------------

Well, if it's been there since 1.9 and this is the first time it's been reported, it hasn't caused the world to stop yet. So I don't think it's worth the work unless we have to spin another 3.0 for additional reasons.

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

DM Smith
In reply to this post by Prajeeth Emanuel (Jira)
Since this is a bug fix, please mark it for 2.9.2 if there ever is one.

On Nov 23, 2009, at 7:08 PM, Michael McCandless (JIRA) wrote:

>
>    [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781706#action_12781706 ]
>
> Michael McCandless commented on LUCENE-2092:
> --------------------------------------------
>
> Fixed on trunk... I'll backport to 3.0 once Uwe opens it up...
>
>> BooleanQuery.hashCode and equals ignore isCoordDisabled
>> -------------------------------------------------------
>>
>>                Key: LUCENE-2092
>>                URL: https://issues.apache.org/jira/browse/LUCENE-2092
>>            Project: Lucene - Java
>>         Issue Type: Bug
>>         Components: Query/Scoring
>>   Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>>           Reporter: Hoss Man
>>           Assignee: Michael McCandless
>>        Attachments: LUCENE-2092.patch
>>
>>
>> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
>> bug traces back to at least 1.9
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-2092:
----------------------------------

    Fix Version/s: 3.1
                   3.0.1
                   2.9.2

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>             Fix For: 2.9.2, 3.0.1, 3.1
>
>         Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781804#action_12781804 ]

Uwe Schindler commented on LUCENE-2092:
---------------------------------------

bq. Well, if it's been there since 1.9 and this is the first time it's been reported, it hasn't caused the world to stop yet. So I don't think it's worth the work unless we have to spin another 3.0 for additional reasons.

+1

But you can commit to *3.0* branch and also *2.9* branch. I did'nt want to have commits in 3.0, because if I respin a release, I would not be able to only take *some* of the fixes into 3.0.0. That was the reason.

For now i marked this issue as fix for 3.1, 3.0.1, 2.9.2

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>             Fix For: 2.9.2, 3.0.1, 3.1
>
>         Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

Prajeeth Emanuel (Jira)
In reply to this post by Prajeeth Emanuel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-2092.
----------------------------------------

    Resolution: Fixed

Fixed in trunk, 3.0.x branch, 2.9.x branch.  Thanks Hoss!

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
>                 Key: LUCENE-2092
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2092
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>            Reporter: Hoss Man
>            Assignee: Michael McCandless
>             Fix For: 2.9.2, 3.0.1, 3.1
>
>         Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]