[jira] Created: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)
MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
------------------------------------------------------------------------

                 Key: LUCENE-2136
                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Index
            Reporter: Michael McCandless
            Assignee: Michael McCandless
             Fix For: 3.1


Related to LUCENE-2130....

Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.

Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.

Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2136:
---------------------------------------

    Attachment: LUCENE-2136-trunk.patch

Patch for trunk.

> MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE-2136-trunk.patch
>
>
> Related to LUCENE-2130....
> Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.
> Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.
> Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2136:
---------------------------------------

    Fix Version/s: Flex Branch

> MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2136-trunk.patch
>
>
> Related to LUCENE-2130....
> Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.
> Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.
> Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787443#action_12787443 ]

Uwe Schindler commented on LUCENE-2136:
---------------------------------------

+1
looks good and is really simple.

> MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2136-trunk.patch
>
>
> Related to LUCENE-2130....
> Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.
> Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.
> Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787447#action_12787447 ]

Michael McCandless commented on LUCENE-2136:
--------------------------------------------

I have flex version coming shortly, then I'll commit.

> MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2136-trunk.patch
>
>
> Related to LUCENE-2130....
> Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.
> Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.
> Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2136:
---------------------------------------

    Attachment: LUCENE-2136-flex.patch

Flex version of patch.  I only patched flex APIs here.... on next merge from trunk we'll pull fix for non-flex over.

> MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2136-flex.patch, LUCENE-2136-trunk.patch
>
>
> Related to LUCENE-2130....
> Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.
> Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.
> Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2136) MultiReader should not use PQ for its Term/sEnum if it has only 1 reader

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-2136.
----------------------------------------

    Resolution: Fixed

> MultiReader should not use PQ for its Term/sEnum if it has only 1 reader
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2136
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Flex Branch, 3.1
>
>         Attachments: LUCENE-2136-flex.patch, LUCENE-2136-trunk.patch
>
>
> Related to LUCENE-2130....
> Even though we've switched to segment-based searching, there are still times when the Term/sEnum is used against the top-level reader.  I think Solr does this, and from LUCENE-2130, certain rewrite modes of MTQ will do this as well.
> Currently, on an optimized index, MTQ is still using a PQ to present the terms, which is silly because this just adds a sizable amount of overhead.  In such cases we should simply delecate to the single segment.
> Note that the single segment can have deletions, and we should still delegate.  Ie, the index need not be optimized, just have a single segment.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]