[jira] Created: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org
Replace SegmentReader.Ref with AtomicInteger
--------------------------------------------

                 Key: LUCENE-2137
                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
             Project: Lucene - Java
          Issue Type: Improvement
            Reporter: Earwin Burrfoot


The title says it all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Earwin Burrfoot updated LUCENE-2137:
------------------------------------

    Description: I think the patch should be applied to backcompat tag in its entirety.  (was: The title says it all.)

> Replace SegmentReader.Ref with AtomicInteger
> --------------------------------------------
>
>                 Key: LUCENE-2137
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>         Attachments: LUCENE-2137.patch
>
>
> I think the patch should be applied to backcompat tag in its entirety.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Earwin Burrfoot updated LUCENE-2137:
------------------------------------

    Attachment: LUCENE-2137.patch

> Replace SegmentReader.Ref with AtomicInteger
> --------------------------------------------
>
>                 Key: LUCENE-2137
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>         Attachments: LUCENE-2137.patch
>
>
> The title says it all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-2137:
------------------------------------------

    Assignee: Michael McCandless

> Replace SegmentReader.Ref with AtomicInteger
> --------------------------------------------
>
>                 Key: LUCENE-2137
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2137.patch
>
>
> I think the patch should be applied to backcompat tag in its entirety.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787776#action_12787776 ]

Uwe Schindler commented on LUCENE-2137:
---------------------------------------

I backwards branch we should only change tests (as we want to test if a drop-in replacement still works). But never change the src/java folder in BW. So the only option in BW is to comment out that tests, as running them will fail. The functionality is tested by the trunk tests.

Else +1, its rather straightforward; I should have seen this during the Lucene 3.0 police audition :-)

> Replace SegmentReader.Ref with AtomicInteger
> --------------------------------------------
>
>                 Key: LUCENE-2137
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2137.patch
>
>
> I think the patch should be applied to backcompat tag in its entirety.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/LUCENE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787789#action_12787789 ]

Michael McCandless commented on LUCENE-2137:
--------------------------------------------

I'll remove/comment out the affected back-compat tests.

> Replace SegmentReader.Ref with AtomicInteger
> --------------------------------------------
>
>                 Key: LUCENE-2137
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2137.patch
>
>
> I think the patch should be applied to backcompat tag in its entirety.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2137) Replace SegmentReader.Ref with AtomicInteger

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-2137.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.1

Thanks Earwin!

> Replace SegmentReader.Ref with AtomicInteger
> --------------------------------------------
>
>                 Key: LUCENE-2137
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2137
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: LUCENE-2137.patch
>
>
> I think the patch should be applied to backcompat tag in its entirety.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]