[jira] Created: (LUCENE-2525) make MultiPhraseQuery's UnionDocsAndPositionsEnum public

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2525) make MultiPhraseQuery's UnionDocsAndPositionsEnum public

Michael Gibney (Jira)
make MultiPhraseQuery's UnionDocsAndPositionsEnum public
--------------------------------------------------------

                 Key: LUCENE-2525
                 URL: https://issues.apache.org/jira/browse/LUCENE-2525
             Project: Lucene - Java
          Issue Type: Bug
          Components: Index
    Affects Versions: 4.0
            Reporter: Michael McCandless
            Assignee: Michael McCandless
             Fix For: 4.0


Somehow during flex development, we (unnecessarily, I think) lost the public oal.index.MultiTermPositions, absorbing it into MultiPhraseQuery as a private class.  We should move it back to oal.index, and make it public again.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2525) make MultiPhraseQuery's UnionDocsAndPositionsEnum public

Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2525:
---------------------------------------

    Attachment: LUCENE-2525.patch

Attached simple patch; I'll commit shortly.

> make MultiPhraseQuery's UnionDocsAndPositionsEnum public
> --------------------------------------------------------
>
>                 Key: LUCENE-2525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2525
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 4.0
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-2525.patch
>
>
> Somehow during flex development, we (unnecessarily, I think) lost the public oal.index.MultiTermPositions, absorbing it into MultiPhraseQuery as a private class.  We should move it back to oal.index, and make it public again.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2525) make MultiPhraseQuery's UnionDocsAndPositionsEnum public

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885056#action_12885056 ]

Uwe Schindler commented on LUCENE-2525:
---------------------------------------

As far as I remember we left out those combined enums for now, as we have no sultion, how to handle Attributes with it. This is the same as MultiTermsEnum & Co. See LUCENE-2154.

> make MultiPhraseQuery's UnionDocsAndPositionsEnum public
> --------------------------------------------------------
>
>                 Key: LUCENE-2525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2525
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 4.0
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-2525.patch
>
>
> Somehow during flex development, we (unnecessarily, I think) lost the public oal.index.MultiTermPositions, absorbing it into MultiPhraseQuery as a private class.  We should move it back to oal.index, and make it public again.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2525) make MultiPhraseQuery's UnionDocsAndPositionsEnum public

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885058#action_12885058 ]

Michael McCandless commented on LUCENE-2525:
--------------------------------------------

Ahh so that was a reason...

But: I don't think this is a reason to make this class private, now?  First off, we have at least one user who was using it and now misses it... second off, we are uncertain still how LUCENE-2154 will/should be solved, or even when it will be.

In the worst case, we would simply declare (in the future) that this UnionDocsAndPositions cannot handle attrs at all, and it'll still be a useful class, right?

> make MultiPhraseQuery's UnionDocsAndPositionsEnum public
> --------------------------------------------------------
>
>                 Key: LUCENE-2525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2525
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 4.0
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-2525.patch
>
>
> Somehow during flex development, we (unnecessarily, I think) lost the public oal.index.MultiTermPositions, absorbing it into MultiPhraseQuery as a private class.  We should move it back to oal.index, and make it public again.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]