[jira] Created: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
StringHelper#stringDifference is wrong about supplementary chars
-----------------------------------------------------------------

                 Key: LUCENE-2643
                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 3.0.2, 3.0.1, 3.0
            Reporter: Simon Willnauer
            Assignee: Simon Willnauer
            Priority: Trivial
             Fix For: 3.0.3, 3.1, 4.0


StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2643:
------------------------------------

    Attachment: LUCENE-2643.patch

here is a patch

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909253#action_12909253 ]

Robert Muir commented on LUCENE-2643:
-------------------------------------

My vote would be to drop it if we arent using it, its @lucene.internal.

since its unused, its not obvious that its "wrong" (its correct if you want the first code unit difference)


> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909256#action_12909256 ]

Simon Willnauer commented on LUCENE-2643:
-----------------------------------------

bq. since its unused, its not obvious that its "wrong" (its correct if you want the first code unit difference)

yeah - my interpretation would be its wrong since you use Character.charAt(int) with the index of the first code unit. anyway - we should drop for trunk but I am not sure if we should for 3.x. I mean this is not that much of a deal anyway.

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909260#action_12909260 ]

Robert Muir commented on LUCENE-2643:
-------------------------------------

drop in trunk and mark deprecated in 3.x?

regardless of whether its right or wrong, if we arent using it, i think its good to clean house.


> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909385#action_12909385 ]

Simon Willnauer commented on LUCENE-2643:
-----------------------------------------

bq. drop in trunk and mark deprecated in 3.x?
yeah that makes sense... shall we fix it in 3.x (fix means support  suppl. chars)? I don't have strong feelings about it.

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2643:
--------------------------------

    Attachment: LUCENE-2643.patch

patch to deprecate (we should just remove from trunk though!)

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922458#action_12922458 ]

Simon Willnauer commented on LUCENE-2643:
-----------------------------------------

bq. patch to deprecate (we should just remove from trunk though!)

+1 - I committed that in 1024128

thanks robert

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922465#action_12922465 ]

Simon Willnauer commented on LUCENE-2643:
-----------------------------------------

I also merged into 3_x - should we backport to 3.0.x too?

simon

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922493#action_12922493 ]

Michael McCandless commented on LUCENE-2643:
--------------------------------------------

Why not drop it from 3.x/3.0.x as well?

It's an internal API so there's no need to deprecate it first?

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922547#action_12922547 ]

Robert Muir commented on LUCENE-2643:
-------------------------------------

+1 to at least removing from 4.0.

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922874#action_12922874 ]

Simon Willnauer commented on LUCENE-2643:
-----------------------------------------

Lets drop it from 4.0 and 3.x and deprecate in the 3.0 branch so if we do a 3.0.3 release one day people get a heads up.

thoughts?

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922885#action_12922885 ]

Michael McCandless commented on LUCENE-2643:
--------------------------------------------

bq. Lets drop it from 4.0 and 3.x and deprecate in the 3.0 branch so if we do a 3.0.3 release one day people get a heads up.

I think doing anything in 3.0.x is optional here... above & beyond the call of duty ;)

And we should drop it in 3.x and 4.0.

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2643:
--------------------------------

    Fix Version/s:     (was: 3.0.3)

moving out

> StringHelper#stringDifference is wrong about supplementary chars
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch, LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since this is not used internally at all we should think about removing it but I guess since it is not too complex we should just or fix it for bwcompat reasons. For released versions we should really fix it since folks might use it though. For trunk we could just drop it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]