[jira] Created: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency

Luís Filipe Nassif (Jira)
BytesRefHash#get() should expect a BytesRef instances for consistency
---------------------------------------------------------------------

                 Key: LUCENE-2702
                 URL: https://issues.apache.org/jira/browse/LUCENE-2702
             Project: Lucene - Java
          Issue Type: Improvement
    Affects Versions: 4.0
            Reporter: Simon Willnauer
            Assignee: Simon Willnauer


BytesRefHash#get should use a provided BytesRef instances instead of the internally used scratch. This is how all other APIs currently work and we should be consistent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency

Luís Filipe Nassif (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2702:
------------------------------------

    Attachment: LUCENE-2702.patch

here is a patch

> BytesRefHash#get() should expect a BytesRef instances for consistency
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2702
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2702
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>         Attachments: LUCENE-2702.patch
>
>
> BytesRefHash#get should use a provided BytesRef instances instead of the internally used scratch. This is how all other APIs currently work and we should be consistent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency

Luís Filipe Nassif (Jira)
In reply to this post by Luís Filipe Nassif (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920892#action_12920892 ]

Uwe Schindler commented on LUCENE-2702:
---------------------------------------

+1, thanks for taking care!. As soon as this is committed I can change the patch for LUCENE-2690.

Is BytesRefHash#get(int) currently not used anywhere except tests, because you had to change nothing?

> BytesRefHash#get() should expect a BytesRef instances for consistency
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2702
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2702
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>         Attachments: LUCENE-2702.patch
>
>
> BytesRefHash#get should use a provided BytesRef instances instead of the internally used scratch. This is how all other APIs currently work and we should be consistent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency

Luís Filipe Nassif (Jira)
In reply to this post by Luís Filipe Nassif (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920895#action_12920895 ]

Simon Willnauer commented on LUCENE-2702:
-----------------------------------------

bq. Is BytesRefHash#get(int) currently not used anywhere except tests, because you had to change nothing?
no currently not since consumers like TermVectorsTermsWriter go through the ParallelPostingsArray and access the shared ByteBlockPool directly - they somewhat bypass the get method call though. We left that in during the refactoring.

bq. +1, thanks for taking care!. As soon as this is committed I can change the patch for LUCENE-2690.
alright - I might do that in one go though.

> BytesRefHash#get() should expect a BytesRef instances for consistency
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2702
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2702
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>         Attachments: LUCENE-2702.patch
>
>
> BytesRefHash#get should use a provided BytesRef instances instead of the internally used scratch. This is how all other APIs currently work and we should be consistent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2702) BytesRefHash#get() should expect a BytesRef instances for consistency

Luís Filipe Nassif (Jira)
In reply to this post by Luís Filipe Nassif (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer resolved LUCENE-2702.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

committed in rev. 1022453

> BytesRefHash#get() should expect a BytesRef instances for consistency
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2702
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2702
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-2702.patch
>
>
> BytesRefHash#get should use a provided BytesRef instances instead of the internally used scratch. This is how all other APIs currently work and we should be consistent.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]