[jira] Created: (LUCENE-2734) Use IndexWriterConfig in benchmark

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
Use IndexWriterConfig in benchmark
----------------------------------

                 Key: LUCENE-2734
                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
             Project: Lucene - Java
          Issue Type: Improvement
          Components: contrib/benchmark
    Affects Versions: 4.0
            Reporter: Simon Willnauer
            Priority: Minor
             Fix For: 4.0
         Attachments: LUCENE-2734.patch

We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer reassigned LUCENE-2734:
---------------------------------------

    Assignee: Simon Willnauer

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2734:
------------------------------------

    Attachment: LUCENE-2734.patch

cut over to IndexWriterConfig. I also made the index writer version configurable since this was not consistent really. Open index used LUCENE_CURRENT while other used LUCENE_31

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927358#action_12927358 ]

Shai Erera commented on LUCENE-2734:
------------------------------------

Is this the patch file you intended to include? :)

{code}
20 Iterations with 4 Concurrent Searchers on a 10M Doc Wikipedia Index Java Heap Space Delta: +368M (corresponds to the file size on disk)
Java Settings: -Xmx2G -Xmx2G
MMap -> Memory Mapped Directory Implementation
NIOFS -> Java NIO Based Directory Implementation
RAM -> Naive RAM Directory loading tii and tis files into memory. (Term Dictionary)
....
{code}

At least, that's what I get when I download it.

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2734:
------------------------------------

    Attachment: LUCENE-2734.patch

well this seems more like a patch :) thx shai

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-2734:
------------------------------------

    Attachment:     (was: LUCENE-2734.patch)

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927757#action_12927757 ]

Shai Erera commented on LUCENE-2734:
------------------------------------

Looks good to me. Are you planning to backport to 3x as well?

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927785#action_12927785 ]

Simon Willnauer commented on LUCENE-2734:
-----------------------------------------

bq. Looks good to me. Are you planning to backport to 3x as well?

sure!

> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2734) Use IndexWriterConfig in benchmark

Soren Daugaard (Jira)
In reply to this post by Soren Daugaard (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer resolved LUCENE-2734.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.1

Trunk: Committed revision 1031097
branch_3x: Committed revision 1031101.


> Use IndexWriterConfig in benchmark
> ----------------------------------
>
>                 Key: LUCENE-2734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2734
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2734.patch
>
>
> We should use IndexWriterConfig instead of deprecated methods in benchmark.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]