[jira] Created: (LUCENE-2803) FieldCache should not pay attention to deleted docs when creating entries

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-2803) FieldCache should not pay attention to deleted docs when creating entries

Hudson (Jira)
FieldCache should not pay attention to deleted docs when creating entries
-------------------------------------------------------------------------

                 Key: LUCENE-2803
                 URL: https://issues.apache.org/jira/browse/LUCENE-2803
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Yonik Seeley


The FieldCache uses a key that ignores deleted docs, so it's actually a bug to use deleted docs when creating an entry.  It can lead to incorrect values when the same entry is used with a different reader.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-2803) FieldCache should not pay attention to deleted docs when creating entries

Hudson (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated LUCENE-2803:
---------------------------------

    Attachment: LUCENE-2803.patch

Here's the patch... pretty simple, so I plan on committing shortly.

> FieldCache should not pay attention to deleted docs when creating entries
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-2803
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2803
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: LUCENE-2803.patch
>
>
> The FieldCache uses a key that ignores deleted docs, so it's actually a bug to use deleted docs when creating an entry.  It can lead to incorrect values when the same entry is used with a different reader.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2803) FieldCache should not pay attention to deleted docs when creating entries

Hudson (Jira)
In reply to this post by Hudson (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968488#action_12968488 ]

Ryan McKinley commented on LUCENE-2803:
---------------------------------------

if checkMatchAllBits always has a null first parameter, should we just take it out?

> FieldCache should not pay attention to deleted docs when creating entries
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-2803
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2803
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: LUCENE-2803.patch
>
>
> The FieldCache uses a key that ignores deleted docs, so it's actually a bug to use deleted docs when creating an entry.  It can lead to incorrect values when the same entry is used with a different reader.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-2803) FieldCache should not pay attention to deleted docs when creating entries

Hudson (Jira)
In reply to this post by Hudson (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968534#action_12968534 ]

Yonik Seeley commented on LUCENE-2803:
--------------------------------------

bq. if checkMatchAllBits always has a null first parameter, should we just take it out?

done.

> FieldCache should not pay attention to deleted docs when creating entries
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-2803
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2803
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: LUCENE-2803.patch
>
>
> The FieldCache uses a key that ignores deleted docs, so it's actually a bug to use deleted docs when creating an entry.  It can lead to incorrect values when the same entry is used with a different reader.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-2803) FieldCache should not pay attention to deleted docs when creating entries

Hudson (Jira)
In reply to this post by Hudson (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved LUCENE-2803.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

committed.  I'm not super happy with the verbiage in CHANGES.txt, so please feel free to improve.

Note: this is also a problem in 2.9 and 3.x, but any fix would be much more difficult since deleted docs are screened out at a very low level int he APIs.

> FieldCache should not pay attention to deleted docs when creating entries
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-2803
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2803
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2803.patch
>
>
> The FieldCache uses a key that ignores deleted docs, so it's actually a bug to use deleted docs when creating an entry.  It can lead to incorrect values when the same entry is used with a different reader.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]