[jira] [Created] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
Make EasySimilarityProvider a full-fledged class
-------------------------------------------------

                 Key: LUCENE-3391
                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
             Project: Lucene - Java
          Issue Type: Sub-task
            Reporter: David Mark Nemeskey
            Assignee: David Mark Nemeskey




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mark Nemeskey updated LUCENE-3391:
----------------------------------------

    Component/s:     (was: modules/examples)
    Description: The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.
         Labels: gsoc gsoc2011 rank similarity  (was: )

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mark Nemeskey updated LUCENE-3391:
----------------------------------------

    Attachment: LUCENE-3391.patch

EasySimilarityProvider added.

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mark Nemeskey updated LUCENE-3391:
----------------------------------------

    Attachment: LUCENE-3391.patch

Hinted at EasySimilarityProvider in the package javadoc.

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mark Nemeskey updated LUCENE-3391:
----------------------------------------

    Attachment: LUCENE-3391.patch

Got rid of BM25SimilarityProvider.

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088705#comment-13088705 ]

Robert Muir commented on LUCENE-3391:
-------------------------------------

a few comments:
* I think we should avoid the generics here? also I think the private sim should be final.
* If the idea is to use for non-vector space sims, I think we should return 1 for coord() by default? in my tests it sometimes totally hoses the ranking for e.g. probabilistic models.
* We can also rethink the naming in that regard? its just a Similarity provider that always returns the same similarity?

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088743#comment-13088743 ]

David Mark Nemeskey commented on LUCENE-3391:
---------------------------------------------

(1) I was also hesitant to add the generics, because I wasn't sure about the warnings it gave. So I'll remove that happily.
(2) And I guess the method parameter in queryNorm?
(3) I'm pretty bad at naming things, so I'd take your advice in this. :) Is BasicSimilarityProvider OK?

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mark Nemeskey updated LUCENE-3391:
----------------------------------------

    Attachment: LUCENE-3391.patch

Fixed the issues you mentioned.

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LUCENE-3391) Make EasySimilarityProvider a full-fledged class

Igor Motov (Jira)
In reply to this post by Igor Motov (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3391.
---------------------------------

    Resolution: Fixed

Thanks David!

> Make EasySimilarityProvider a full-fledged class
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good candidate for a full-fledged class. Both {{DefaultSimilarity}} and {{BM25Similarity}} have their own providers, which are effectively the same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]