[jira] [Created] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)
FilteredDocIdSet does not handle a case where the inner set iterator is null
----------------------------------------------------------------------------

                 Key: LUCENE-3816
                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
             Project: Lucene - Java
          Issue Type: Bug
          Components: core/search
    Affects Versions: 3.5
            Reporter: Shay Banon
         Attachments: LUCENE-3816.patch

DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.

The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shay Banon updated LUCENE-3816:
-------------------------------

    Attachment: LUCENE-3816.patch

Patch attached.
               

> FilteredDocIdSet does not handle a case where the inner set iterator is null
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.5
>            Reporter: Shay Banon
>         Attachments: LUCENE-3816.patch
>
>
> DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.
> The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler reassigned LUCENE-3816:
-------------------------------------

    Assignee: Uwe Schindler
   

> FilteredDocIdSet does not handle a case where the inner set iterator is null
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.5
>            Reporter: Shay Banon
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-3816.patch
>
>
> DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.
> The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213592#comment-13213592 ]

Uwe Schindler commented on LUCENE-3816:
---------------------------------------

Tha nks for reporting this, I will check and commit trunk and 3.x branch!
               

> FilteredDocIdSet does not handle a case where the inner set iterator is null
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.5
>            Reporter: Shay Banon
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-3816.patch
>
>
> DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.
> The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3816:
----------------------------------

    Fix Version/s: 4.0
                   3.6
   

> FilteredDocIdSet does not handle a case where the inner set iterator is null
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.5
>            Reporter: Shay Banon
>            Assignee: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3816.patch
>
>
> DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.
> The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3816:
----------------------------------

    Attachment: LUCENE-3816.patch

Patch with a new test that verifies this works. Fails without Shay's patch.

Will commit now.
               

> FilteredDocIdSet does not handle a case where the inner set iterator is null
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.5
>            Reporter: Shay Banon
>            Assignee: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3816.patch, LUCENE-3816.patch
>
>
> DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.
> The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LUCENE-3816) FilteredDocIdSet does not handle a case where the inner set iterator is null

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler resolved LUCENE-3816.
-----------------------------------

    Resolution: Fixed

Committed trunk revision: 1292282
Committed 3.x revision: 1292288

Thanks Shay!
               

> FilteredDocIdSet does not handle a case where the inner set iterator is null
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3816
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3816
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 3.5
>            Reporter: Shay Banon
>            Assignee: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3816.patch, LUCENE-3816.patch
>
>
> DocIdSet#iterator is allowed to return null, when used in FilteredDocIdSet, if null is returned from the inner set, the FilteredDocIdSetIterator fails since it does not allow for nulls to be passed to it.
> The fix is simple, return null in FilteredDocIdSet in the iterator method is the iterator is null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]