[jira] Created: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
Calculate MD5 checksums in target <dist-all>
--------------------------------------------

                 Key: LUCENE-904
                 URL: https://issues.apache.org/jira/browse/LUCENE-904
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Build
            Reporter: Michael Busch
            Assignee: Michael Busch
            Priority: Trivial
             Fix For: 2.2


Trivial patch that extends the ant target <dist-all> to calculate
the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch updated LUCENE-904:
---------------------------------

    Attachment: lucene-904.patch

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501097 ]

Hoss Man commented on LUCENE-904:
---------------------------------

FWIW ... i put something like this in the solr build.xml a while back, but discovered the format ant's <checksum> task uses by default is really trivial and doesn't work when people use "md5sum -c" to try and check the sums.  (<checksum> has a "format" attribute now, but that wasn't added until ~Dec2006, so I think it requires ant 1.7)

the way we solved the problem was with the <solr-checksum> macro added to our build.xml in this commit...
http://svn.apache.org/viewvc/lucene/solr/trunk/build.xml?r1=483882&r2=484780

background...
http://www.nabble.com/%22correct%22-format-for-the-md5-files--tf2779495.html#a7754724

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501338 ]

Michael Busch commented on LUCENE-904:
--------------------------------------

> doesn't work when people use "md5sum -c" to try and check the sums.  

True, I just checked it. md5sum -c emits

  "no properly formatted MD5 checksum lines found"

for the .md5 files <checksum> produces without the "format" attribute.  

> (<checksum> has a "format" attribute now, but that wasn't added until
> ~Dec2006, so I think it requires ant 1.7)

Yes it requires 1.7.

> the way we solved the problem was with the <solr-checksum> macro added
> to our build.xml in this commit...

Looks good! Mind me stealing the macro?

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501350 ]

Hoss Man commented on LUCENE-904:
---------------------------------

You can't "steal" the macro, but it is Licensed under the ASL v2.0 (and more explicitly: when i wrote it and committed it to the Solr repository I Licensed it to the ASF for inclusion in ASF works as per the Apache Software License ยง5)

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501380 ]

Michael Busch commented on LUCENE-904:
--------------------------------------

Well, yes that's what I meant. As long as code is licensed to the ASF for inclusion in ASF works it can be copied from project A to project B, as long as both A and B are licensed under the same ASL, right?

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501397 ]

Hoss Man commented on LUCENE-904:
---------------------------------

(for the record: in my last comment i was attempting to be facetious ... i clearly failed)

IANAL but i but as i understand it you are correct, if not then a lot of apache projects are already in a lot of trouble.

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501402 ]

Michael Busch commented on LUCENE-904:
--------------------------------------

Actually my "steal" sentence was supposed to be facetious too :-) I guess we have to improve our communication (<-- this is supposed to be funny, too)

Alright, I will submit a new patch shortly.

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch updated LUCENE-904:
---------------------------------

    Attachment: lucene-904.patch

OK, here is the patch with the macro. And indeed, "md5sum -c" works
fine with the .md5 files.

I'm planning on committing this patch soon.

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch, lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-904) Calculate MD5 checksums in target <dist-all>

Nick Burch (Jira)
In reply to this post by Nick Burch (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Busch resolved LUCENE-904.
----------------------------------

       Resolution: Fixed
    Lucene Fields: [New, Patch Available]  (was: [Patch Available, New])

Committed.

> Calculate MD5 checksums in target <dist-all>
> --------------------------------------------
>
>                 Key: LUCENE-904
>                 URL: https://issues.apache.org/jira/browse/LUCENE-904
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Trivial
>             Fix For: 2.2
>
>         Attachments: lucene-904.patch, lucene-904.patch
>
>
> Trivial patch that extends the ant target <dist-all> to calculate
> the MD5 checksums for the dist files.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]