[jira] Created: (LUCENE-941) Benchmark al line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (LUCENE-941) Benchmark al line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)
Benchmark al line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
----------------------------------------------------------------------

                 Key: LUCENE-941
                 URL: https://issues.apache.org/jira/browse/LUCENE-941
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/benchmark
            Reporter: Doron Cohen
            Assignee: Doron Cohen
             Fix For: 2.3


Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
The line  
   {[AddDoc(4000)]: 4} : *
causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.

To fix this the DocMaker exhastion check shuld be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-941) Benchmark alg line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-941:
-------------------------------

       Priority: Minor  (was: Major)
    Description:
Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
The line  
   {[AddDoc(4000)]: 4} : *
causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.

To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

  was:
Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
The line  
   {[AddDoc(4000)]: 4} : *
causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.

To fix this the DocMaker exhastion check shuld be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

        Summary: Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop  (was: Benchmark al line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop)

> Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-941
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>
> Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
> The line  
>    {[AddDoc(4000)]: 4} : *
> causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.
> To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-941) Benchmark alg line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527139 ]

Michael McCandless commented on LUCENE-941:
-------------------------------------------

Doron are you working on this one?  I think we want to release 2.3 pretty soon and this one is marked with 2.3 fix version.

> Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-941
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>
> Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
> The line  
>    {[AddDoc(4000)]: 4} : *
> causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.
> To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-941) Benchmark alg line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-941:
-------------------------------

    Attachment: lucene-941-patch.txt

Attached a test demonstrating the bug and a fix for it.
I will commit it in a few days unless there are any concerns.


> Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-941
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-941-patch.txt
>
>
> Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
> The line  
>    {[AddDoc(4000)]: 4} : *
> causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.
> To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (LUCENE-941) Benchmark alg line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-941:
-------------------------------

    Attachment: lucene-941-patch.txt

Previous fix did not cover the case of a ResetInput task after exhaustion.
Updated patch is fixing this case as well.

> Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-941
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-941-patch.txt, lucene-941-patch.txt
>
>
> Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
> The line  
>    {[AddDoc(4000)]: 4} : *
> causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.
> To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (LUCENE-941) Benchmark alg line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528313 ]

Doron Cohen commented on LUCENE-941:
------------------------------------

Two notes on current patch:
- Two ResetSystem Tasks now subclass ResetInputsTask.
- Unlike initially intended, fix is mainly in TaskSequence, not relying on DocMakers, so that it can easily be extended to work with other "makers".

> Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-941
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-941-patch.txt, lucene-941-patch.txt
>
>
> Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
> The line  
>    {[AddDoc(4000)]: 4} : *
> causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.
> To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (LUCENE-941) Benchmark alg line - {[AddDoc(4000)]: 4} : * - causes an infinite loop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen resolved LUCENE-941.
--------------------------------

       Resolution: Fixed
    Lucene Fields:   (was: [New])

fixed.

> Benchmark alg line -  {[AddDoc(4000)]: 4} : * - causes an infinite loop
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-941
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: lucene-941-patch.txt, lucene-941-patch.txt
>
>
> Background in http://www.mail-archive.com/java-dev@.../msg10831.html 
> The line  
>    {[AddDoc(4000)]: 4} : *
> causes an infinite loop because the parallel sequence would mask the exhaustion from the outer sequential sequence.
> To fix this the DocMaker exhaustion check should be modified to rely  on the doc maker instance only, and to be reset when the inputs are being reset.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]