[jira] Created: (NUTCH-227) Basic Query Filter no more uses Configuration

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NUTCH-227) Basic Query Filter no more uses Configuration

Sebastian Nagel (Jira)
Basic Query Filter no more uses Configuration
---------------------------------------------

         Key: NUTCH-227
         URL: http://issues.apache.org/jira/browse/NUTCH-227
     Project: Nutch
        Type: Bug
  Components: searcher  
    Versions: 0.8-dev    
    Reporter: Jerome Charron
 Assigned to: Jerome Charron
     Fix For: 0.8-dev


Since NUTCH-169, the BasicIndexingFilter has no way to retrieve its configuration parameters (query.url.boost, query.anchor.boost, query.title.boost, query.host.boost, query.phrase.boost) : The setConf(Configuration) method is never called by the QueryFilters class.

More generaly, we should provide a way for QueryFilter to be Configurable. Two solutions:
1. The QueryFilters checks that a QueryFilter implements Configurable and then call the setConf() method.
2. QueryFilter extends Configurable => all QueryFilter must implement Configurable.

My preference goes to 1, and if there is no objection, I will commit a patch in the next few days.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-227) Basic Query Filter no more uses Configuration

Sebastian Nagel (Jira)
    [ http://issues.apache.org/jira/browse/NUTCH-227?page=comments#action_12369660 ]

Andrzej Bialecki  commented on NUTCH-227:
-----------------------------------------

Isn't it so that QueryFilter (which is an interface) already extends Configurable? What seems to be missing in QueryFilters.java is a call to setConf(), around line 73.

> Basic Query Filter no more uses Configuration
> ---------------------------------------------
>
>          Key: NUTCH-227
>          URL: http://issues.apache.org/jira/browse/NUTCH-227
>      Project: Nutch
>         Type: Bug
>   Components: searcher
>     Versions: 0.8-dev
>     Reporter: Jerome Charron
>     Assignee: Jerome Charron
>      Fix For: 0.8-dev

>
> Since NUTCH-169, the BasicIndexingFilter has no way to retrieve its configuration parameters (query.url.boost, query.anchor.boost, query.title.boost, query.host.boost, query.phrase.boost) : The setConf(Configuration) method is never called by the QueryFilters class.
> More generaly, we should provide a way for QueryFilter to be Configurable. Two solutions:
> 1. The QueryFilters checks that a QueryFilter implements Configurable and then call the setConf() method.
> 2. QueryFilter extends Configurable => all QueryFilter must implement Configurable.
> My preference goes to 1, and if there is no objection, I will commit a patch in the next few days.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-227) Basic Query Filter no more uses Configuration

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)
    [ http://issues.apache.org/jira/browse/NUTCH-227?page=comments#action_12369665 ]

Marko Bauhardt commented on NUTCH-227:
--------------------------------------

take a look to Extension.java line: 151 to 154.
Object object = extensionClazz.newInstance();
        if(object instanceof Configurable) {
            ((Configurable)object).setConf(this.conf);
        }

Isn't that already setting the configuration? Also QueryFilter extends Configurable.

> Basic Query Filter no more uses Configuration
> ---------------------------------------------
>
>          Key: NUTCH-227
>          URL: http://issues.apache.org/jira/browse/NUTCH-227
>      Project: Nutch
>         Type: Bug
>   Components: searcher
>     Versions: 0.8-dev
>     Reporter: Jerome Charron
>     Assignee: Jerome Charron
>      Fix For: 0.8-dev

>
> Since NUTCH-169, the BasicIndexingFilter has no way to retrieve its configuration parameters (query.url.boost, query.anchor.boost, query.title.boost, query.host.boost, query.phrase.boost) : The setConf(Configuration) method is never called by the QueryFilters class.
> More generaly, we should provide a way for QueryFilter to be Configurable. Two solutions:
> 1. The QueryFilters checks that a QueryFilter implements Configurable and then call the setConf() method.
> 2. QueryFilter extends Configurable => all QueryFilter must implement Configurable.
> My preference goes to 1, and if there is no objection, I will commit a patch in the next few days.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (NUTCH-227) Basic Query Filter no more uses Configuration

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)
     [ http://issues.apache.org/jira/browse/NUTCH-227?page=all ]
     
Jerome Charron closed NUTCH-227:
--------------------------------

    Resolution: Fixed

Oups.. sorry guys... and thanks for you prompt remarks.
All is in fact OK.

> Basic Query Filter no more uses Configuration
> ---------------------------------------------
>
>          Key: NUTCH-227
>          URL: http://issues.apache.org/jira/browse/NUTCH-227
>      Project: Nutch
>         Type: Bug
>   Components: searcher
>     Versions: 0.8-dev
>     Reporter: Jerome Charron
>     Assignee: Jerome Charron
>      Fix For: 0.8-dev

>
> Since NUTCH-169, the BasicIndexingFilter has no way to retrieve its configuration parameters (query.url.boost, query.anchor.boost, query.title.boost, query.host.boost, query.phrase.boost) : The setConf(Configuration) method is never called by the QueryFilters class.
> More generaly, we should provide a way for QueryFilter to be Configurable. Two solutions:
> 1. The QueryFilters checks that a QueryFilter implements Configurable and then call the setConf() method.
> 2. QueryFilter extends Configurable => all QueryFilter must implement Configurable.
> My preference goes to 1, and if there is no objection, I will commit a patch in the next few days.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (NUTCH-227) Basic Query Filter no more uses Configuration

Jérôme Charron
In fact, my first need was to be able to configure the boost for
RawFieldQueryFilter.
The idea is then to give to the user a better control of boost values by
simply :
* add a setBoost(float) method to RawFieldQueryFilter.
* (add a setLowerCase(boolean) method to RawFieldQueryFilter)
* Add some configuration properties for boost values for actual
RawFieldQueryFilters: (CC|Type|RelTag|Site|Language)QueryFilter

Do you think it makes sense to commit such changes?
(or is it just a very focused need I actually have)

Jérôme

--
http://motrech.free.fr/
http://www.frutch.org/
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (NUTCH-227) Basic Query Filter no more uses Configuration

Stefan Groschupf-2
Jérôme,
+1
Having the chance to write query filters that allows more control in  
general would be very helpful.
Stefan

Am 09.03.2006 um 18:35 schrieb Jérôme Charron:

> In fact, my first need was to be able to configure the boost for
> RawFieldQueryFilter.
> The idea is then to give to the user a better control of boost  
> values by
> simply :
> * add a setBoost(float) method to RawFieldQueryFilter.
> * (add a setLowerCase(boolean) method to RawFieldQueryFilter)
> * Add some configuration properties for boost values for actual
> RawFieldQueryFilters: (CC|Type|RelTag|Site|Language)QueryFilter
>
> Do you think it makes sense to commit such changes?
> (or is it just a very focused need I actually have)
>
> Jérôme
>
> --
> http://motrech.free.fr/
> http://www.frutch.org/

---------------------------------------------------------------
company:        http://www.media-style.com
forum:        http://www.text-mining.org
blog:            http://www.find23.net