[jira] [Created] (NUTCH-2765) Unify and cleanup X509TrustManager

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Created] (NUTCH-2765) Unify and cleanup X509TrustManager

Kenneth William Krugler (Jira)
Sebastian Nagel created NUTCH-2765:

             Summary: Unify and cleanup X509TrustManager
                 Key: NUTCH-2765
                 URL: https://issues.apache.org/jira/browse/NUTCH-2765
             Project: Nutch
          Issue Type: Improvement
          Components: protocol
    Affects Versions: 1.16
            Reporter: Sebastian Nagel
             Fix For: 1.17

Multiple plugins use a separate implementation of the [javax.net.ssl.X509TrustManager|https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/X509TrustManager.html] to optionally skip TLS certificate checks (NUTCH-2647).

- protocol-httpclient, protocol-http, and with NUTCH-2649 also protocol-selenium, protocol-interactiveselenium, protocol-htmlunit use identical copies of DummyX509TrustManager
 1. there should be a single class implementation either in the plugin lib-http or in the core package org.apache.nutch.net.protocols
 2. the DummyX509TrustManager needs a clean up: it still keeps a lot old stuff relating to the [sun.net.ssl.X509TrustManager|https://docs.oracle.com/cd/E17802_01/products/products/jsseforcdc/apidoc/com/sun/net/ssl/X509TrustManager.html] interface
- protocol-okhttp includes a minimalistic anonymous class implementing X509TrustManager

This message was sent by Atlassian Jira