[jira] Created: (NUTCH-842) AutoGenerate WebPage code

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (NUTCH-842) AutoGenerate WebPage code

Michael Gibney (Jira)
AutoGenerate WebPage code
-------------------------

                 Key: NUTCH-842
                 URL: https://issues.apache.org/jira/browse/NUTCH-842
             Project: Nutch
          Issue Type: Improvement
            Reporter: Doğacan Güney
            Assignee: Doğacan Güney
             Fix For: 2.0


This issue will track the addition of an ant task that will automatically generate o.a.n.storage.WebPage (and ProtocolStatus and ParseStatus) from src/gora/webpage.avsc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (NUTCH-842) AutoGenerate WebPage code

Michael Gibney (Jira)

     [ https://issues.apache.org/jira/browse/NUTCH-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Nioche updated NUTCH-842:
--------------------------------

    Attachment: NUTCH-842.patch

ANT task (generate-gora-src) for the generation of Java source code from the GORA schema. Shall we do it systematically as part of the build procedure? We should also add the generated classes to svn ignore

> AutoGenerate WebPage code
> -------------------------
>
>                 Key: NUTCH-842
>                 URL: https://issues.apache.org/jira/browse/NUTCH-842
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>             Fix For: 2.0
>
>         Attachments: NUTCH-842.patch
>
>
> This issue will track the addition of an ant task that will automatically generate o.a.n.storage.WebPage (and ProtocolStatus and ParseStatus) from src/gora/webpage.avsc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-842) AutoGenerate WebPage code

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898196#action_12898196 ]

Andrzej Bialecki  commented on NUTCH-842:
-----------------------------------------

I think we can put it as depends in the compile target, but then we need to first check if there's any need to generate, i.e. check the timestamp of WebPage.avsc and WebPage.java and generate only when .avsc is more recent.

Perhaps we should check in generated sources anyway, because if we don't do it then it will be difficult to compile in IDE-s without running Ant first... though to tell the truth it got difficult already when we switched to ivy. Perhaps we need a separate "eclipse" target to resolve dependencies, run gora compiler and generate Eclipse project files?

> AutoGenerate WebPage code
> -------------------------
>
>                 Key: NUTCH-842
>                 URL: https://issues.apache.org/jira/browse/NUTCH-842
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>             Fix For: 2.0
>
>         Attachments: NUTCH-842.patch
>
>
> This issue will track the addition of an ant task that will automatically generate o.a.n.storage.WebPage (and ProtocolStatus and ParseStatus) from src/gora/webpage.avsc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-842) AutoGenerate WebPage code

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898199#action_12898199 ]

Julien Nioche commented on NUTCH-842:
-------------------------------------

{quote}
I think we can put it as depends in the compile target, but then we need to first check if there's any need to generate, i.e. check the timestamp of WebPage.avsc and WebPage.java and generate only when .avsc is more recent.
{quote}

good idea. Do you know how to do that?

{quote}
Perhaps we should check in generated sources anyway, because if we don't do it then it will be difficult to compile in IDE-s without running Ant first... though to tell the truth it got difficult already when we switched to ivy.
{quote}

you are right, let's not make a special case for these sources. If the schemas were to be modified by a user then it would definitely be better to be warned by svn that the files have changed. I can picture accidental changes that would go unnoticed, errors that others would not be able to reproduce etc...

{quote}
Perhaps we need a separate "eclipse" target to resolve dependencies, run gora compiler and generate Eclipse project files?
{quote}
I found that IvyDE was pretty good at managing the dependencies. Let's just leave the generated *.java files in Subversion and keep things as simple as possible



> AutoGenerate WebPage code
> -------------------------
>
>                 Key: NUTCH-842
>                 URL: https://issues.apache.org/jira/browse/NUTCH-842
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>             Fix For: 2.0
>
>         Attachments: NUTCH-842.patch
>
>
> This issue will track the addition of an ant task that will automatically generate o.a.n.storage.WebPage (and ProtocolStatus and ParseStatus) from src/gora/webpage.avsc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (NUTCH-842) AutoGenerate WebPage code

Michael Gibney (Jira)
In reply to this post by Michael Gibney (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898314#action_12898314 ]

Chris A. Mattmann commented on NUTCH-842:
-----------------------------------------

Hey Guys,

I was able to get everything working in Eclipse with IvyDE and with the mods I made to ivy.xml and ivy-dependencies.xml for Gora. After that, and clicking resolve dependencies in Eclipse (after installing Gora to Ivy locally), all worked fine.

About storing the generated java files in SVN -- I could go either way on this. If we can cook up an easy way to autogenerate them, then why not, and then add to svn:ignore?

Cheers,
Chris


> AutoGenerate WebPage code
> -------------------------
>
>                 Key: NUTCH-842
>                 URL: https://issues.apache.org/jira/browse/NUTCH-842
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Doğacan Güney
>            Assignee: Doğacan Güney
>             Fix For: 2.0
>
>         Attachments: NUTCH-842.patch
>
>
> This issue will track the addition of an ant task that will automatically generate o.a.n.storage.WebPage (and ProtocolStatus and ParseStatus) from src/gora/webpage.avsc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.