[jira] Created: (SOLR-1573) Replication stats page for slaves not displaying two lines of master information

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-1573) Replication stats page for slaves not displaying two lines of master information

Tim Allison (Jira)
Replication stats page for slaves not displaying two lines of master information
--------------------------------------------------------------------------------

                 Key: SOLR-1573
                 URL: https://issues.apache.org/jira/browse/SOLR-1573
             Project: Solr
          Issue Type: Bug
          Components: web gui
    Affects Versions: 1.4
            Reporter: Jay Hill
            Priority: Minor


On the admin page for replication, on a slave host, there used to be 3 lines of information about the master:
LIne 1: master url, i.e. http://foo.bar:8983/solr/core0/replication
Line 2: Information about the master, i.e. "Latest Index Version 123456, Generation: 16
Line 3: More master inro, i.e. "Replicatable Index Version 123456, Generation: 16

But now only Line 1 is displaying. There is a block of code in ...replication/index.jsp where this is displayed that never seems to drop into:

<%
    if (nl != null) {        
      nl = (NamedList) nl.get("master");
      if(nl != null){      
  %>
<tr>  
  <td>
  </td>
  <td>Latest Index Version:<%=nl.get("indexVersion")%>, Generation: <%=nl.get("generation")%>
  </td>
</tr>
<tr>
  <td></td>
  <td>Replicatable Index Version:<%=nl.get("replicatableIndexVersion")%>, Generation: <%=nl.get("replicatableGeneration")%>
  </td>
</tr>
<%
}
}%>

Those bits of information were quite useful when comparing the slave versions to the master.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-1573) Replication stats page for slaves not displaying two lines of master information

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul reassigned SOLR-1573:
--------------------------------

    Assignee: Noble Paul

> Replication stats page for slaves not displaying two lines of master information
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-1573
>                 URL: https://issues.apache.org/jira/browse/SOLR-1573
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.4
>            Reporter: Jay Hill
>            Assignee: Noble Paul
>            Priority: Minor
>
> On the admin page for replication, on a slave host, there used to be 3 lines of information about the master:
> LIne 1: master url, i.e. http://foo.bar:8983/solr/core0/replication
> Line 2: Information about the master, i.e. "Latest Index Version 123456, Generation: 16
> Line 3: More master inro, i.e. "Replicatable Index Version 123456, Generation: 16
> But now only Line 1 is displaying. There is a block of code in ...replication/index.jsp where this is displayed that never seems to drop into:
> <%
>     if (nl != null) {        
>       nl = (NamedList) nl.get("master");
>       if(nl != null){      
>   %>
> <tr>  
>   <td>
>   </td>
>   <td>Latest Index Version:<%=nl.get("indexVersion")%>, Generation: <%=nl.get("generation")%>
>   </td>
> </tr>
> <tr>
>   <td></td>
>   <td>Replicatable Index Version:<%=nl.get("replicatableIndexVersion")%>, Generation: <%=nl.get("replicatableGeneration")%>
>   </td>
> </tr>
> <%
> }
> }%>
> Those bits of information were quite useful when comparing the slave versions to the master.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1573) Replication stats page for slaves not displaying two lines of master information

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782025#action_12782025 ]

Mark Miller commented on SOLR-1573:
-----------------------------------

Looks like this was pulled at one point?

{code}
    if (nl != null) {
      long masterVersion = (Long) nl.get("indexversion");
      long masterGeneration = (Long) nl.get("generation");
      long replicatableMasterVer = 0, replicatableMasterGen = 0;
      if (nl.get("replicatableindexversion") != null)
        replicatableMasterVer = (Long) nl.get("replicatableindexversion");
      if (nl.get("replicatablegeneration") != null)
        replicatableMasterGen = (Long) nl.get("replicatablegeneration");
{code}

> Replication stats page for slaves not displaying two lines of master information
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-1573
>                 URL: https://issues.apache.org/jira/browse/SOLR-1573
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.4
>            Reporter: Jay Hill
>            Assignee: Noble Paul
>            Priority: Minor
>
> On the admin page for replication, on a slave host, there used to be 3 lines of information about the master:
> LIne 1: master url, i.e. http://foo.bar:8983/solr/core0/replication
> Line 2: Information about the master, i.e. "Latest Index Version 123456, Generation: 16
> Line 3: More master inro, i.e. "Replicatable Index Version 123456, Generation: 16
> But now only Line 1 is displaying. There is a block of code in ...replication/index.jsp where this is displayed that never seems to drop into:
> <%
>     if (nl != null) {        
>       nl = (NamedList) nl.get("master");
>       if(nl != null){      
>   %>
> <tr>  
>   <td>
>   </td>
>   <td>Latest Index Version:<%=nl.get("indexVersion")%>, Generation: <%=nl.get("generation")%>
>   </td>
> </tr>
> <tr>
>   <td></td>
>   <td>Replicatable Index Version:<%=nl.get("replicatableIndexVersion")%>, Generation: <%=nl.get("replicatableGeneration")%>
>   </td>
> </tr>
> <%
> }
> }%>
> Those bits of information were quite useful when comparing the slave versions to the master.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1573) Replication stats page for slaves not displaying two lines of master information

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782027#action_12782027 ]

Mark Miller commented on SOLR-1573:
-----------------------------------

Nevermind - that code is still there, just different - whats happening is that this info needs to come from "masterDetails" - and we grab "masterDetails" - but before we pull the info from the nl we load up, we replace it with "master" - which doen't exist - because its a slave - so the lines don't get printed:

{code}
   <%
    NamedList nl = (NamedList) slave.get("masterDetails");
    if(nl == null)
    out.print(" - <b>Unreachable</b>");
    %>

    if (nl != null) {        
      nl = (NamedList) nl.get("master");
      if(nl != null){      

    // I believe this stuff is actually in masterDetails, not master
    Latest Index Version:<%=nl.get("indexVersion")%>, Generation: <%=nl.get("generation")%>
 
    Replicatable Index Version:<%=nl.get("replicatableIndexVersion")%>, Generation: <%=nl.get("replicatableGeneration")%>
 
{code}

> Replication stats page for slaves not displaying two lines of master information
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-1573
>                 URL: https://issues.apache.org/jira/browse/SOLR-1573
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.4
>            Reporter: Jay Hill
>            Assignee: Noble Paul
>            Priority: Minor
>
> On the admin page for replication, on a slave host, there used to be 3 lines of information about the master:
> LIne 1: master url, i.e. http://foo.bar:8983/solr/core0/replication
> Line 2: Information about the master, i.e. "Latest Index Version 123456, Generation: 16
> Line 3: More master inro, i.e. "Replicatable Index Version 123456, Generation: 16
> But now only Line 1 is displaying. There is a block of code in ...replication/index.jsp where this is displayed that never seems to drop into:
> <%
>     if (nl != null) {        
>       nl = (NamedList) nl.get("master");
>       if(nl != null){      
>   %>
> <tr>  
>   <td>
>   </td>
>   <td>Latest Index Version:<%=nl.get("indexVersion")%>, Generation: <%=nl.get("generation")%>
>   </td>
> </tr>
> <tr>
>   <td></td>
>   <td>Replicatable Index Version:<%=nl.get("replicatableIndexVersion")%>, Generation: <%=nl.get("replicatableGeneration")%>
>   </td>
> </tr>
> <%
> }
> }%>
> Those bits of information were quite useful when comparing the slave versions to the master.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.