[jira] Created: (SOLR-1620) log message "created null" misleading

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-1620) log message "created null" misleading

Tim Allison (Jira)
log message "created null" misleading
-------------------------------------

                 Key: SOLR-1620
                 URL: https://issues.apache.org/jira/browse/SOLR-1620
             Project: Solr
          Issue Type: Bug
    Affects Versions: 1.4
            Reporter: KuroSaka TeruHiko
            Priority: Minor


Solr logs a message like this:
{noformat}
INFO: created null: org.apache.solr.analysis.LowerCaseFilterFactory
{noformat}

This sounds like the TokenFilter or Tokenizer were not created and a serious error.  But it mealy means the component is not named.  "null" is printed because the local variable "name" has the value null.

This is misleading.

If the text field type is not named, it should just print blank, rather than the word "null".

I would suggest that a line in src/java/org/apache/solr/util/plugin/AbstractPluginLoader.java be changed to:
{noformat}
          log.info("created"+((name!=null)?(" "+name):"")+": " + plugin.getClass().getName() );
{noformat}
from
{noformat}
          log.info("created "+name+": " + plugin.getClass().getName() );
{noformat}




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-1620) log message "created null" misleading

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar reassigned SOLR-1620:
-------------------------------------------

    Assignee: Shalin Shekhar Mangar

> log message "created null" misleading
> -------------------------------------
>
>                 Key: SOLR-1620
>                 URL: https://issues.apache.org/jira/browse/SOLR-1620
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: KuroSaka TeruHiko
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Solr logs a message like this:
> {noformat}
> INFO: created null: org.apache.solr.analysis.LowerCaseFilterFactory
> {noformat}
> This sounds like the TokenFilter or Tokenizer were not created and a serious error.  But it mealy means the component is not named.  "null" is printed because the local variable "name" has the value null.
> This is misleading.
> If the text field type is not named, it should just print blank, rather than the word "null".
> I would suggest that a line in src/java/org/apache/solr/util/plugin/AbstractPluginLoader.java be changed to:
> {noformat}
>           log.info("created"+((name!=null)?(" "+name):"")+": " + plugin.getClass().getName() );
> {noformat}
> from
> {noformat}
>           log.info("created "+name+": " + plugin.getClass().getName() );
> {noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-1620) log message "created null" misleading

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-1620.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5

Committed revision 888282.

Thanks KuroSaka!

> log message "created null" misleading
> -------------------------------------
>
>                 Key: SOLR-1620
>                 URL: https://issues.apache.org/jira/browse/SOLR-1620
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: KuroSaka TeruHiko
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.5
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Solr logs a message like this:
> {noformat}
> INFO: created null: org.apache.solr.analysis.LowerCaseFilterFactory
> {noformat}
> This sounds like the TokenFilter or Tokenizer were not created and a serious error.  But it mealy means the component is not named.  "null" is printed because the local variable "name" has the value null.
> This is misleading.
> If the text field type is not named, it should just print blank, rather than the word "null".
> I would suggest that a line in src/java/org/apache/solr/util/plugin/AbstractPluginLoader.java be changed to:
> {noformat}
>           log.info("created"+((name!=null)?(" "+name):"")+": " + plugin.getClass().getName() );
> {noformat}
> from
> {noformat}
>           log.info("created "+name+": " + plugin.getClass().getName() );
> {noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.