[jira] Created: (SOLR-1648) Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-1648) Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter

Tim Allison (Jira)
Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter
-----------------------------------------------------------------

                 Key: SOLR-1648
                 URL: https://issues.apache.org/jira/browse/SOLR-1648
             Project: Solr
          Issue Type: Improvement
          Components: Response Writers
    Affects Versions: 1.4, 1.3, 1.2
         Environment: My local MacBook pro over the Christmas Break.
            Reporter: Chris A. Mattmann
             Fix For: 1.5


The current XMLWriter class is kind of a misnomer. It's not a generic XMLWriter by any means, and that's not its intention. Its intention is to write instances (as responses) of a particular XML schema that SOLR clients (written in Java, Python, pick-your-favorite-programming-language) that speak its XML protocol can understand. So, we should rename it to SolrXmlResponseWriter to indicate its unique XML speak.

Morever, as part of the next issue I'm going to report (refactoring all ResponseWriters to be a bit more friendly), we should probably do away with the current XmlResponseWriter (which simply delegates to XmlWriter -- eeep) and just stick with SolrXmlResponseWriter. Patch forthcoming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-1648) Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter

Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789682#action_12789682 ]

Chris A. Mattmann commented on SOLR-1648:
-----------------------------------------

See this thread for more detail:

http://www.lucidimagination.com/search/document/e8bb6cac84c1f520/namespaces_in_response_solr_1586#cc50ba9e9d8fe2dc

> Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter
> -----------------------------------------------------------------
>
>                 Key: SOLR-1648
>                 URL: https://issues.apache.org/jira/browse/SOLR-1648
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: My local MacBook pro over the Christmas Break.
>            Reporter: Chris A. Mattmann
>             Fix For: 1.5
>
>
> The current XMLWriter class is kind of a misnomer. It's not a generic XMLWriter by any means, and that's not its intention. Its intention is to write instances (as responses) of a particular XML schema that SOLR clients (written in Java, Python, pick-your-favorite-programming-language) that speak its XML protocol can understand. So, we should rename it to SolrXmlResponseWriter to indicate its unique XML speak.
> Morever, as part of the next issue I'm going to report (refactoring all ResponseWriters to be a bit more friendly), we should probably do away with the current XmlResponseWriter (which simply delegates to XmlWriter -- eeep) and just stick with SolrXmlResponseWriter. Patch forthcoming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.