[jira] Created: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
Solr should get it's temp dir like lucene - first checking the tempDir sys prop
-------------------------------------------------------------------------------

                 Key: SOLR-2011
                 URL: https://issues.apache.org/jira/browse/SOLR-2011
             Project: Solr
          Issue Type: Improvement
          Components: Build
            Reporter: Mark Miller
            Assignee: Mark Miller
            Priority: Minor
             Fix For: Next




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891388#action_12891388 ]

Robert Muir commented on SOLR-2011:
-----------------------------------

by the way, in LuceneTestCase[J4] which now all Solr base test classes extend, there is:

{code}
   /** Create indexes in this directory, optimally use a subdir, named after the test */
  public static final File TEMP_DIR;
{code}

so you can just access this to get your temp dir. I think we just need to make sure solr's build.xml's set the right sysprops,
but this would make it consistent with lucene easily?


> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: Next
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-2011:
------------------------------

    Attachment: SOLR-2011.patch

attached is an initial patch... (it only fixes solr core, but I think we can fix contrib build.xml's the same way).

One benefit is that since temp stuff goes in build/ like lucene: on windows, 'ant clean'
will remove spellchecker indexes or other leftover stuff that couldnt be deleted in tearDown(),
rather than littering your system temp directory.


> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-2011:
------------------------------

    Attachment: SOLR-2011.patch

updated patch that also sets the sysprop for solr contribs.

> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894585#action_12894585 ]

Robert Muir commented on SOLR-2011:
-----------------------------------

if no one objects, I'd like to commit this soon.

its nice if you are trying to debug SOLR-1873 tests on windows (just run ant clean), otherwise you have to periodically keep tabs on system tempdirs.


> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894587#action_12894587 ]

Yonik Seeley commented on SOLR-2011:
------------------------------------

+1

> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894588#action_12894588 ]

Michael McCandless commented on SOLR-2011:
------------------------------------------

Tests all pass for me on Fedora 13.

> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller reassigned SOLR-2011:
---------------------------------

    Assignee: Robert Muir  (was: Mark Miller)

+1

> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894614#action_12894614 ]

Robert Muir commented on SOLR-2011:
-----------------------------------

Committed revision 981598, 981609 (3x)

I'll attach a patch shortly that cleans up the rest of the uses of java.io.tmpdir

> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-2011:
------------------------------

    Attachment: SOLR-2011_temps.patch

here is a patch for the rest of the uses of java.io.tmpdir (basedistributedtestcase and a few others)


> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch, SOLR-2011_temps.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2011) Solr should get it's temp dir like lucene - first checking the tempDir sys prop

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved SOLR-2011.
-------------------------------

    Fix Version/s: 3.1
                   4.0
                       (was: Next)
       Resolution: Fixed

Committed the rest of java.io.tmpdir -> TEMP_DIR in revision 981650, 981657 (3x)

> Solr should get it's temp dir like lucene - first checking the tempDir sys prop
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2011
>                 URL: https://issues.apache.org/jira/browse/SOLR-2011
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mark Miller
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2011.patch, SOLR-2011.patch, SOLR-2011_temps.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]