[jira] Created: (SOLR-2280) commitWithin ignored for a delete query

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
commitWithin ignored for a delete query
---------------------------------------

                 Key: SOLR-2280
                 URL: https://issues.apache.org/jira/browse/SOLR-2280
             Project: Solr
          Issue Type: Bug
          Components: clients - java
            Reporter: David Smiley
            Priority: Minor


The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
{code:java}
UpdateRequest request = new UpdateRequest();
request.deleteById("id123");
request.setCommitWithin(1000);
solrServer.request(request);
{code}

In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969874#action_12969874 ]

Yonik Seeley commented on SOLR-2280:
------------------------------------

+1

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038560#comment-13038560 ]

Jan Høydahl commented on SOLR-2280:
-----------------------------------

+1 I have client side code explicitly working around this bug, would be nice with a fix in 3.2

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-2280:
------------------------------

    Fix Version/s: 3.2

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.2
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juan Grande updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch

I'm submitting a patch that implements commitWithin on deletes. The patch is for the 3x branch.

Two things should be noted:
# The commit is fired even if the delete doesn't really delete any document.
# When using the BinaryUpdateRequestHandler the params of the UpdateRequest are loaded when parsing the docs. If the request doesn't include a docs list, then the params aren't loaded. I added a workaround for this, but SOLR-1164 should solve this problem definitely.


> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149959#comment-13149959 ]

Jan Høydahl commented on SOLR-2280:
-----------------------------------

Juan, would you care uploading a new patch which applies cleanly to 3.x (or trunk)? This looks like a nice addition to the other commitWithin improvements in 3.x.

Also, could you find a way to test commitWithin without adding 20 seconds of waitForCommit() to the test time? Waits in the tests have also proven unreliable..
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.5, 4.0
>
>         Attachments: SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151394#comment-13151394 ]

Juan Grande commented on SOLR-2280:
-----------------------------------

Hi Jan,

I'm working on it, I will upload a new patch shortly. I'll update the tests to use the same approach as in SOLR-2565.

               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.5, 4.0
>
>         Attachments: SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juan Grande updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch

Here's the new patch, it applies to 3x branch.
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 3.5, 4.0
>
>         Attachments: SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl reassigned SOLR-2280:
---------------------------------

    Assignee: Jan Høydahl
   

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch
                SOLR-2280-3x.patch

Here's a patch for trunk (SOLR-2280.patch). I've also tested and slightly updated the 3x patch, and named it SOLR-2280-3x.patch.

PS: Juan - we normally create patches using "project" as root, not solr/.

Test coverage is good. One or two more eyes on it and I think it's ready for commit.
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159994#comment-13159994 ]

Jan Høydahl commented on SOLR-2280:
-----------------------------------

I also plan to add in support for the convenience methods deleteById(String id, int commitWithinMs) etc in SolrJ the same way as for adds.
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch
                SOLR-2280-3x.patch

New patches which adds new commitWithin capable SolrJ methods for deleteBy*()
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177627#comment-13177627 ]

Juan Grande commented on SOLR-2280:
-----------------------------------

Hi Jan, is there something else that I can do to keep this patch moving on?
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch

New patch against trunk.

Added support for commitWithin as request parameter on deletes for XML and JSON loaders. Tested ok.

Think this is getting close. Any other comments? Would like to get this into 3x soon.
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-2280:
------------------------------

    Attachment: SOLR-2280.patch
                SOLR-2280-3x.patch

Final patches, backported to 3x
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl resolved SOLR-2280.
-------------------------------

    Resolution: Fixed

Fixed on trunk and 3x
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234052#comment-13234052 ]

huangfox commented on SOLR-2280:
--------------------------------

I create a method deleteById(String id , int commitWithinMs) in solrJ(solr3.5),
 but committing is affected by solrconfig.xml(<maxTime>60000</maxTime>)  
--
Add the document is valid .

               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234166#comment-13234166 ]

Jan Høydahl commented on SOLR-2280:
-----------------------------------

Hi huangfox. Please ask questions on the solr-user mailing list, not here. See http://wiki.apache.org/solr/UsingMailingLists
               

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (SOLR-2280) commitWithin ignored for a delete query

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man reassigned SOLR-2280:
------------------------------

    Assignee: Juan Grande  (was: Jan Høydahl)
   

> commitWithin ignored for a delete query
> ---------------------------------------
>
>                 Key: SOLR-2280
>                 URL: https://issues.apache.org/jira/browse/SOLR-2280
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: David Smiley
>            Assignee: Juan Grande
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280-3x.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch, SOLR-2280.patch
>
>
> The commitWithin option on an UpdateRequest is only honored for requests containing new documents.  It does not, for example, work with a delete query.  The following doesn't work as expected:
> {code:java}
> UpdateRequest request = new UpdateRequest();
> request.deleteById("id123");
> request.setCommitWithin(1000);
> solrServer.request(request);
> {code}
> In my opinion, the commitWithin attribute should be  permitted on the <delete/> xml tag as well as <add/>.  Such a change would go in XMLLoader.java and its would have some ramifications elsewhere too.  Once this is done, then UpdateRequest.getXml() can be updated to generate the right XML.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]