[jira] [Created] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
LogLevelSelection Servlet outputs plain HTML
--------------------------------------------

                 Key: SOLR-2459
                 URL: https://issues.apache.org/jira/browse/SOLR-2459
             Project: Solr
          Issue Type: Wish
          Components: web gui
            Reporter: Stefan Matheis (steffkes)
            Priority: Trivial


The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!

Just as an Idea for a future structure, the new admin-ui is [https://github.com/steffkes/solr-admin/blob/master/logging.json|actually based on that json-structure] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Matheis (steffkes) updated SOLR-2459:
--------------------------------------------

    Description:
The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!

Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

  was:
The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!

Just as an Idea for a future structure, the new admin-ui is [https://github.com/steffkes/solr-admin/blob/master/logging.json|actually based on that json-structure] :)


> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042046#comment-13042046 ]

Upayavira commented on SOLR-2459:
---------------------------------

So, slf4j is a facade, and it looks like Solr uses JDK logging behind that. I'm assuming this is correct.

It seems that the best way to do this is to replace the LogLevelSelection servlet with a Handler.

Coding a handler to display current settings is easy, and I've already done it. However, to code the update side, requires a decision on suitable request parameters.

The biggest question is whether to allow multiple settings to be changed in one request. The current LogLevelSelection servlet allows you to change them all in one single hit. However, allowing this in a new Handler would, in my opinion, give rise to an ugly API. Therefore, I suggest that:

http://localhost:8983/solr/admin/logging   <- would display current settings
http://localhost:8983/solr/admin/logging?category=core&level=FINE   <- would change a single value

This latter would probably output the same as the previous, but perhaps with an 'updated' attribute set to true on that category.

Given the ajax nature of the new UI, I suspect this would be enough for it to work with.

Thoughts?

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042056#comment-13042056 ]

Stefan Matheis (steffkes) commented on SOLR-2459:
-------------------------------------------------

Upayavira,

thanks for having a look into this!

bq. Thoughts?
Yes, just a simple one -- GET for requesting Data and POST for changing them, please :)

bq. The biggest question is whether to allow multiple settings to be changed in one request. The current LogLevelSelection servlet allows you to change them all in one single hit. However, allowing this in a new Handler would, in my opinion, give rise to an ugly API.
Don't know much about the handling of arrays in java .. in php it's pretty easy? For the Interface it would be okay to generate such an structure for an HTTP-Request: {code}logging[org.apache.solr.core.JmxMonitoredMap]=INFO&logging[org.apache.solr.update.UpdateHandler]=FINEST{code}
Given that Information you could loop over it, and set every Logger at the specified Level. Of course we need to define how we could reset/delete a Loggers-Setting ..

Stefan

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042078#comment-13042078 ]

Upayavira commented on SOLR-2459:
---------------------------------

Well, Solr doesn't distinguish between GET and POST in its handlers as far as I can see, so either would work.

If by POST you mean that you would post some XML or JSON to it, and it would use that, that could be done (don't know how hard it is to accept JSON, but could look into it).

Upayavira


> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042124#comment-13042124 ]

Stefan Matheis (steffkes) commented on SOLR-2459:
-------------------------------------------------

bq. Well, Solr doesn't distinguish between GET and POST in its handlers as far as I can see, so either would work.
Ah okay .. good to know!

bq. If by POST you mean that you would post some XML or JSON to it, and it would use that, that could be done (don't know how hard it is to accept JSON, but could look into it).
No, not really - just POSTing the Params and don't append them to the url; because some older browser has low restrictions to the length of an url -- and while using POST the size/amount of data does not matter. i think there is no need to support xml/json here, the data is plain key/value .. it's enough :>

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042129#comment-13042129 ]

Upayavira commented on SOLR-2459:
---------------------------------

As far as a Handler is concerned, it is just a list of key/value pairs, regardless of whether POSTed or in the URL of a GET. (at least, that is my current understanding).

Perhaps it could be:

logging.category=org.apache.org.solr.core.JmxMonitoredMap
logging.level=INFO

Or, as an alternative:

logging.category.org.apache.solr.core.JmxMonitoredMap=INFO
logging.category.org.apache.solr.update.UpdateHandler=FINEST

Either would be acceptable.


> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042135#comment-13042135 ]

Ryan McKinley commented on SOLR-2459:
-------------------------------------

I like:
bq. logging.category=org.apache.org.solr.core.JmxMonitoredMap
bq. logging.level=INFO

As for actually updating the logging value....  what is the plan for supporting various logging providers like Log4j?  The handler gets initialized with the logging framework and it takes care of translating the levels (FINEST == TRACE etc)?

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042160#comment-13042160 ]

Upayavira commented on SOLR-2459:
---------------------------------

Ryan,

I'd implement both approaches - the latter might allow Stefan more flexibility in building a UI on top of it. (in fact, I have both coded, now looking at test cases).

At present, this is intentionally a rewrite of the LogLevelSelection servlet, which only works with JDK logging. I'm just plagiarising the logging code from there.

If we want to be more clever, and work with other frameworks, I'm up for it, but it is extending the scope somewhat!


> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042172#comment-13042172 ]

Ryan McKinley commented on SOLR-2459:
-------------------------------------

great -- my comment about supporting log4j is just to keep it in mind.  Sometimes its easier to think about the abstraction earlier, but we can obviously tackle that in a follow on issue.

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042177#comment-13042177 ]

Stefan Matheis (steffkes) commented on SOLR-2459:
-------------------------------------------------

{quote}Perhaps it could be:
logging.category=org.apache.org.solr.core.JmxMonitoredMap
logging.level=INFO{quote}
What would really mean, that we can just update one Logger (per Step) -- changing five of them will result in: click, change; save, click, change, save; click, change, save .. and so on? We could "autosave" every change instantly, but that's something we don't have anywhere else yet - so i guess users were wondering about that behaviour?

{quote}Or, as an alternative:
logging.category.org.apache.solr.core.JmxMonitoredMap=INFO
logging.category.org.apache.solr.update.UpdateHandler=FINEST{quote}
{quote}I'd implement both approaches - the latter might allow Stefan more flexibility in building a UI on top of it. {quote}
It's of course possible, but it would be easier to have something like that:
{code}logging[category.org.apache.solr.core.JmxMonitoredMap]=INFO
logging[category.org.apache.solr.update.UpdateHandler]=FINEST{code}
There it's possible to setup an initial Hashmap and just put all the Loggers into it. Or is that really difficult to handle on the Server-Side?

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042185#comment-13042185 ]

Ryan McKinley commented on SOLR-2459:
-------------------------------------

what about somethign like:
{code}
/admin/logging?set=category.org.apache.solr.core.JmxMonitoredMap:INFO
{code}
and setting multiple items with:
{code}
/admin/logging?set=category.org.apache.solr.core.JmxMonitoredMap:INFO&set=category.org.apache.solr.update.UpdateHandler:FINEST
{code}

This could work better on the server side then having to iterate though all the parameters and checking if they are relevant.



> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042189#comment-13042189 ]

Upayavira commented on SOLR-2459:
---------------------------------

Ryan - that could work, and it makes it clear that it is an 'action'.

Stefan - I'm trying to make a decent public API that is consistent with the rest of Solr. Sorry if that makes it harder for you!!

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Upayavira updated SOLR-2459:
----------------------------

    Attachment: sample-output.json
                sample-output.xml
                LogLevelHandler.patch

Here's a first pass at the handler. I'm sure the output format is wrong, but the (limited) tests pass (it changes a value, then puts it back).

I've included an XML and a JSON sample output.

Is this more or less what we're after?


> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042692#comment-13042692 ]

Stefan Matheis (steffkes) commented on SOLR-2459:
-------------------------------------------------

bq. Stefan - I'm trying to make a decent public API that is consistent with the rest of Solr. Sorry if that makes it harder for you!!
That's okay .. instead of using one command, i have to combine a few .. but everything is better then now ;>

bq. I've included an XML and a JSON sample output.
Nice! Just thought about the following things:
* Is {{unset}} really a valid Level? It's more a command to remove a active Logger, no?
* {{unset=true}} (inside the <loggers>-tag) shows that this logger has no specific setting, right? if so, perhaps just drop this out and only have the effective.level info?



> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043061#comment-13043061 ]

Upayavira commented on SOLR-2459:
---------------------------------

Stefan - with set=, you can do multiples, so set=foo:INFO&set=bar:FINEST&set=baz:FINE The patch as it stands supports that.

unset=true comes about when the logging system reports a category, but no value ( or null). So the logging system knows about it, but doesn't have a setting. My understanding is that this is where 'effective level' kicks in, that's the one that'll be used.




> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2459) LogLevelSelection Servlet outputs plain HTML

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2459:
--------------------------------

    Attachment: SOLR-2459-LogLevel.patch

updating patch to trunk.

I will now try to generalize it so that it could have a Log4J (or whatever) backend
               

> LogLevelSelection Servlet outputs plain HTML
> --------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, SOLR-2459-LogLevel.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2459) Implement LogLevelSelection as a RequestHandler

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2459:
--------------------------------

    Summary: Implement LogLevelSelection as a RequestHandler  (was: LogLevelSelection Servlet outputs plain HTML)
   

> Implement LogLevelSelection as a RequestHandler
> -----------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, SOLR-2459-LogLevel.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2459) Implement LogLevelSelection as a RequestHandler

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2459:
--------------------------------

    Attachment: SOLR-2459-LogLevel.patch

An updated/simplified generic version that uses the SolrTestCaseJ4

The format is different, but seems to match the JS needs better.

I will commit this soon so the UI stuff can continue in a different issue
               

> Implement LogLevelSelection as a RequestHandler
> -----------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, SOLR-2459-LogLevel.patch, SOLR-2459-LogLevel.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2459) Implement LogLevelSelection as a RequestHandler

Markus Jelsma (Jira)
In reply to this post by Markus Jelsma (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214193#comment-13214193 ]

Ryan McKinley commented on SOLR-2459:
-------------------------------------

Added in revision: 1292617

Lets keep the existing servlet in place until the admin UI works
               

> Implement LogLevelSelection as a RequestHandler
> -----------------------------------------------
>
>                 Key: SOLR-2459
>                 URL: https://issues.apache.org/jira/browse/SOLR-2459
>             Project: Solr
>          Issue Type: Wish
>          Components: web gui
>            Reporter: Stefan Matheis (steffkes)
>            Priority: Trivial
>         Attachments: LogLevelHandler.patch, SOLR-2459-LogLevel.patch, SOLR-2459-LogLevel.patch, sample-output.json, sample-output.xml
>
>
> The current available Output of the LogLevelSelection Servlet is plain HTML, which made it unpossible, to integrate the Logging-Information in the new Admin-UI. Format-Agnostic Output (like every [?] other Servlet offers) would be really nice!
> Just as an Idea for a future structure, the new admin-ui is [actually based on that json-structure|https://github.com/steffkes/solr-admin/blob/master/logging.json] :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12