[jira] Created: (SOLR-267) log handler + query +

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-267) log handler + query +

Tim Allison (Jira)
log handler + query +
----------------------

                 Key: SOLR-267
                 URL: https://issues.apache.org/jira/browse/SOLR-267
             Project: Solr
          Issue Type: Improvement
          Components: search
    Affects Versions: 1.3
            Reporter: Will Johnson
            Priority: Minor
             Fix For: 1.3


adds a logger



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query +

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

hit a random key a little fast on the last post.  the attached patch adds a logger to the Standard and DisMax request handlers to log the hander name, query string and hit count for each query.  

> log handler + query +
> ----------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch
>
>
> adds a logger

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Description:
adds a logger to log handler, query string and hit counts for each query



  was:
adds a logger



        Summary: log handler + query + hits  (was: log handler + query + )

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506656 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

I think in the future we could handle this in a more generic manner, but for now I'd support a more generic version implemented in SolrCore.execute()
It could check for a DocList in element #1 and if so, use that.
That would be faster than a separate logging statement, and the query (and all other parameters passed in) are already logged in execute().

I think we need a separate key=value section for results... and the number of results would appear as "hits=941"


> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

updated patch to work in SolrCore.execute() instead.  i annotated the msg with hits=## as requested however i left time unlabeled for backwards compatibility and i had no idea what the static '0' was but i left it there just to be safe as well.   i think i tmight be good to clean that up and i'm happy to but i don't know who or how those numbers are being used today.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506684 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

The static "0" is return code... no exception was thrown if we are here, so it was a success.

I think the last thing should remain the request time for back compatibility and easy scanning.
The result parameters should go after the input parameters, separated by some sort of delimiter
to be nice to machine parsers.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

Attaching version with small changes...

This produces log messages that look like this:
INFO: /select q=solr&wt=python&indent=on hits=1 0 94

If there was no DocSet, it would look like this:
INFO: /select q=solr&wt=python&indent=on - 0 94

The '-' is a placeholder so the number of fields will be the same for different requests.

I checked, and partialUrlEncode does encode spaces, so a space separator in the log is sufficient.


> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

RE: [jira] Updated: (SOLR-267) log handler + query + hits

Will Johnson
>This produces log messages that look like this:
>INFO: /select q=solr&wt=python&indent=on hits=1 0 94
>
>If there was no DocSet, it would look like this:
>INFO: /select q=solr&wt=python&indent=on - 0 94

I would think that tacking the new stats onto the end of the line would
be better than in the middle.  Usually when I parse log files it
involves something like:

String[] arr = line.split(" ");
code = arr[3]
time = arr[4]

instead of the following which is what it seems you're implying that
people are doing:

String[] arr = line.splti(" ")
code = arr[arr.length-2]
time = arr[arr.length-1]

but then again, I don't have any code written to parse things yet so
backwards compatibility isn't an issue for me and either format is fine.
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Updated: (SOLR-267) log handler + query + hits

Yonik Seeley-2
On 6/21/07, Will Johnson <[hidden email]> wrote:

> >This produces log messages that look like this:
> >INFO: /select q=solr&wt=python&indent=on hits=1 0 94
> >
> >If there was no DocSet, it would look like this:
> >INFO: /select q=solr&wt=python&indent=on - 0 94
>
> I would think that tacking the new stats onto the end of the line would
> be better than in the middle.  Usually when I parse log files it
> involves something like:
>
> String[] arr = line.split(" ");
> code = arr[3]
> time = arr[4]
>
> instead of the following which is what it seems you're implying that
> people are doing:
>
> String[] arr = line.splti(" ")
> code = arr[arr.length-2]
> time = arr[arr.length-1]
>
> but then again, I don't have any code written to parse things yet so
> backwards compatibility isn't an issue for me and either format is fine.

I do have some code, and for times it just went from the end. The
start can vary based on the container config...the resin logs like
this:
[2007-06-21 04:15:58.195] rows=1&start=0&q=contentId:0 0 1

w/o backward compatibility concerns, which looks best?  I don't have a
strong opinion, but I think time at the end makes most sense (maybe
because that's what I'm used to seeing in other logs?)

-Yonik
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

slight update to log the webapp name which is set in the SolrDispatchFilter.  this lets you distinguish between multiple solr instances for tracking purposes.

log output now looks like:

Jun 21, 2007 10:31:05 AM org.apache.solr.core.SolrCore execute
INFO: /solr /select/ indent=on&start=0&q=*:*&version=2.2&rows=10 hits=5 0 62

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507148 ]

Hoss Man commented on SOLR-267:
-------------------------------

I'm really not a fan of this approach to logging the number of hits via SolrCore.execute ... this is request handler specific information, it should be logged by the request handler.

if people really want this type of stuff to be logged by SolrCore execute so that there's only one log message with the timing info and status and such, then let's come up with a way for the RequestHandler to explicitly specify in the SolrQueryResponse the key-val pairs it wants logged (either via new methods on SOlrQueryResponse, or via apecific name at the top level of the response) and modify the out-of-the-box request handlers to take advantage of this

instead of...

+    String resultLog = " -";
+    if (rsp.getValues().size()>1 && rsp.getValues().getVal(1) instanceof DocList) {
+       int hits = ((DocList) rsp.getValues().getVal(1)).size();
+        resultLog = " hits=" + hits;
+    }

...something like...

      StringBuffer resultLog = new StringBuffer(" -");
      Map<String,Object> logables = rsp.getValues().get("loginfo");
      for (String k : logables.keySet()) {
          resultLog.append(" " + k + "=" + logables.get(k));
      }


> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507312 ]

Will Johnson commented on SOLR-267:
-----------------------------------

One thing that comes to mind is making the response header a standard
part of the SolrQueryResponse object with get/set/add methods then the
log message can just print out what ever is in the response header. With
trunk, it already contains much of the same data (status, qtime,
params).  The only issue is that in order to keep things 'clean' the
output would change to being fully labeled:

webapp=/solr path=/select/ status=0 QTime=63
params={indent=on,start=0,q=*:*,version=2.2,rows=10} myotherheader=foo

In general I think this makes things much cleaner and easier to read but
it does break backwards compatibility for log parsing purposes.  Any
other ideas?

- will







> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

new patch to promote responseHeader from a defacto standard to an api standard in SolrQueryResponse.  this enables the SolrCore.execute() method to simply print out it's contents containing any info people want logged.  the format now is:

 Jun 22, 2007 10:37:25 AM org.apache.solr.core.SolrCore execute
INFO: webapp=/solr path=/select/ hits=0 status=0 QTime=0 params={indent=on,start=0,q=solr,version=2.2,rows=10}

which is fully labeled but i think mkaes things much easier to read/parse as you can look for labels instead of positions which may or may not change.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507999 ]

Ian Holsman commented on SOLR-267:
----------------------------------

a couple of comments on this patch.

1. how is this going to look when the query is ~200-1000 characters long? you might need/want to put in some quotes are the query.

2. is it possible to put the metrics into the response header so that tomcat's logging will be able to grab it (similar to how SOLR-232 puts it in)



> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508006 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

I liked the params that I could paste back into my browser...

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508007 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

> I'm really not a fan of this approach to logging the number of hits via SolrCore.execute ... this is request handler specific information, it should be logged by the request handler.

There is something to be said for automatically logging certain things for all request handlers in a certain category (those that produce a "base" DocList or DocSet) rather than requiring each handler to worry about logging code also.

The implementation is slightly hackish at this point, but not too bad.  If/when we go to a QueryComponent chain, it would be cleaner to get "hits".

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508163 ]

Will Johnson commented on SOLR-267:
-----------------------------------

A few response rolled up:

Yonik Seeley commented on SOLR-267:
-----------------------------------


After having used this for a ~week now I kind of do too.  I can work on
a patch that switches that log component back unless someone else (who
wants it more) beats me to it.

"hits".

Agreed, I'd love to have query pipelines and indexing pipelines for
processing logic but that's a much bigger effort.  At the moment it's
only 1 line extra in each of the 'real' query handlers which doesn't
seem too bad.


Ian Holsman commented on SOLR-267:
----------------------------------

long? >you might need/want to put in some quotes are the query.

It will look very long :)  As long as there are no spaces which the url
encoding should handle I think things are ok (this assumes we're going
to switch back to cgi params)

it >in)

Not that I know how to do.  Since the dispatch filter is a filter not a
servlet it doesn't have access to an HttpServletResponse, only a
ServletResponse which means it can't set HttpHeaders.  This was my
original idea for how to solve this problem and seems a bit more
'standard' anyways but I hit a dead end without getting more hackish
than usual.

- will

 


> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

new patch that writes out request params as cgi instead of NL.toString() for pasting into a browser.  i also figured out the HttpResponseHeader however i'm not sure how people feel about having that info duplicated in teh solr logs, the http headers/access logs and the actual solr response.  in any case the following logic would go into SolrDispatchFilter: (but is not in this patch)




> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510550 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

The double logging issue with the new update handler framework should be fixed with whatever mechanism is created here.

Using the responseHeader as logging info is clever, but I'm not sure if we want to be bound to return everything in the response that we want to be logged (for updates, some may want all of the ids logged but not returned, and if they are returned, not in the header).

So, what about either a "NamedList toLog;"on the SolrQueryResponse,  or SolrQueryRequest.getContext().get("log") => NamedList ?

> new patch to promote responseHeader from a defacto standard to an api standard in SolrQueryResponse.

I think that's probably OK



> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Johnson updated SOLR-267:
------------------------------

    Attachment: LogQueryHitCounts.patch

new path produces the following output:

Jul 11, 2007 1:35:19 PM org.apache.solr.core.SolrCore execute
INFO: webapp=/solr path=/select/ params=indent=on&start=0&q=solr&version=2.2&rows=10 hits=0 status=0 QTime=79

and adds a NamedList toLog as yonik suggested.  

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12