[jira] Created: (SOLR-267) log handler + query +

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520633 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

So what do people think of the logging format?  Any objections?

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520691 ]

Hoss Man commented on SOLR-267:
-------------------------------

format looks fine to me, some minor nits from a quick skim of the patch...

1) "protected NamedList toLog" should have some javadocs.

2) "public NamedList getResponseHeader()" seems to have incorrect javadocs

3) I'm pretty sure the use HttpServletResponse.addHeader in SolrDispatchFilter requires that the header names not contains spaces ... that's not something currently guaranteed by solrRsp.getResponseHeader()

4) although the odds of the ClassCastException in SolrDispatchFilter asymptotically approach zero, it should still be logged properly instead of using cce.printStackTrace()



> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas updated SOLR-267:
----------------------------

    Fix Version/s:     (was: 1.3)

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll reassigned SOLR-267:
------------------------------------

    Assignee: Grant Ingersoll

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-267:
---------------------------------

    Attachment: SOLR-267.patch

Updated the patch to run using the new SearchComponent infrastructure.  Also, made a slight change about how params are output so that it is more clear what the params are due to = being both the key/value separator for the log message and the key/value separator for the params.

Plan to commit tonight or tomorrow.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589717#action_12589717 ]

Yonik Seeley commented on SOLR-267:
-----------------------------------

> Also, made a slight change about how params are output so that it is more clear what the params are

Can you give an example of what the output looks like now (and what impact multi-core has, if any)?



> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589728#action_12589728 ]

Grant Ingersoll commented on SOLR-267:
--------------------------------------

{quote}
Can you give an example of what the output looks like now (and what impact multi-core has, if any)?
{quote}
INFO: webapp=/solr path=/select/ params={indent=on&rows=10&start=0&q=ipod&version=2.2} hits=3 status=0 QTime=8

I will have to try w/ MultiCore

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589737#action_12589737 ]

Grant Ingersoll commented on SOLR-267:
--------------------------------------

Here's what happens on multicore:

{code}
Apr 16, 2008 5:40:29 PM org.apache.solr.core.SolrCore execute
INFO: webapp=/solr path=/select/ params={indent=on&rows=10&start=0&q=solr&version=2.2} hits=0 status=0 QTime=39
Apr 16, 2008 5:40:29 PM org.apache.solr.core.SolrCore execute
INFO: [core0] /select/ indent=on&rows=10&start=0&q=solr&version=2.2 0 39
{code}

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-267:
---------------------------------

    Attachment: SOLR-267.patch

Update to remove double logging in SolrCore.  Should now properly handle multicore, etc.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll resolved SOLR-267.
----------------------------------

    Resolution: Fixed

Committed revision 649066.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll reopened SOLR-267:
----------------------------------


Something isn't quite right with regards to the responseHeader.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590088#action_12590088 ]

Grant Ingersoll commented on SOLR-267:
--------------------------------------

OK, two things:

1. The current commit adds responseHeader twice

2. The changes to SolrDispatchFilter can screw up SolrJ when you have explicit=all.  

I don't know enough about how headers work, so I'm going to fix #1 and comment out #2 and put a TODO: there and someone can address it on SOLR-232

Patch shortly

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-267:
---------------------------------

    Attachment: SOLR-267.patch

Will commit shortly

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch, SOLR-267.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-267) log handler + query + hits

Clark Perkins (Jira)
In reply to this post by Clark Perkins (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll resolved SOLR-267.
----------------------------------

    Resolution: Fixed

Committed revision 649185.

> log handler + query + hits
> --------------------------
>
>                 Key: SOLR-267
>                 URL: https://issues.apache.org/jira/browse/SOLR-267
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Will Johnson
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, LogQueryHitCounts.patch, SOLR-267.patch, SOLR-267.patch, SOLR-267.patch
>
>
> adds a logger to log handler, query string and hit counts for each query

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12