[jira] [Created] (SOLR-3272) Solr filter factory for MorfologikFilter

classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
Solr filter factory for MorfologikFilter
----------------------------------------

                 Key: SOLR-3272
                 URL: https://issues.apache.org/jira/browse/SOLR-3272
             Project: Solr
          Issue Type: New Feature
          Components: Schema and Analysis
    Affects Versions: 4.0
            Reporter: Rafał Kuć
             Fix For: 4.0
         Attachments: SOLR-3272.patch

I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafał Kuć updated SOLR-3272:
----------------------------

    Attachment: SOLR-3272.patch

Patch with MorfologikFilterFactory and test added.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss reassigned SOLR-3272:
---------------------------------

    Assignee: Dawid Weiss
   

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238327#comment-13238327 ]

Dawid Weiss commented on SOLR-3272:
-----------------------------------

Hi Michał. Could you modify this patch to include support for the three dictionaries (combined, morfeusz and morfologik)? This would be more flexible (and the combined dictionary is nearly twice larger than morfologik itself so it's worth it).
{code}
return new MorfologikFilter(ts, DICTIONARY.MORFOLOGIK, luceneMatchVersion);
{code}

Also, an example of use in the JavaDoc would be nice (see BeiderMorseFilterFactory for example). The test should be using DEFAULT_VERSION not the fixed LUCENE_40. Thanks!
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Issue Comment Edited] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238327#comment-13238327 ]

Dawid Weiss edited comment on SOLR-3272 at 3/26/12 12:17 PM:
-------------------------------------------------------------

Hi Rafał. Could you modify this patch to include support for the three dictionaries (combined, morfeusz and morfologik)? This would be more flexible (and the combined dictionary is nearly twice larger than morfologik itself so it's worth it).
{code}
return new MorfologikFilter(ts, DICTIONARY.MORFOLOGIK, luceneMatchVersion);
{code}

Also, an example of use in the JavaDoc would be nice (see BeiderMorseFilterFactory for example). The test should be using DEFAULT_VERSION not the fixed LUCENE_40. Thanks!
               
      was (Author: dweiss):
    Hi Michał. Could you modify this patch to include support for the three dictionaries (combined, morfeusz and morfologik)? This would be more flexible (and the combined dictionary is nearly twice larger than morfologik itself so it's worth it).
{code}
return new MorfologikFilter(ts, DICTIONARY.MORFOLOGIK, luceneMatchVersion);
{code}

Also, an example of use in the JavaDoc would be nice (see BeiderMorseFilterFactory for example). The test should be using DEFAULT_VERSION not the fixed LUCENE_40. Thanks!
                 

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238330#comment-13238330 ]

Rafał Kuć commented on SOLR-3272:
---------------------------------

Sure Dawid, no problem. I'll provide a patch later today.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238332#comment-13238332 ]

Dawid Weiss commented on SOLR-3272:
-----------------------------------

Thanks. Sorry about the name confusion btw. Don't know where I took Michał from :)
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafał Kuć updated SOLR-3272:
----------------------------

    Attachment: SOLR-3727-new.patch

Dawid, I've uploaded new patch. One thing I noted is that the ant build throws an error because it can't find Morfologik libraries.

I'll patch the build files tomorrow.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238715#comment-13238715 ]

Dawid Weiss commented on SOLR-3272:
-----------------------------------

Thanks Rafał.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafał Kuć updated SOLR-3272:
----------------------------

    Attachment: SOLR-3272-with-javadoc-example-usage.patch

Dawid, I've looked at the build files and how libs are handled. My proposition is to copy the jar's from the modules/morfologik/lib to solr/contrib/analysis-extras/lib similar to the way the ICU lib is handled. What do you think about that ?

I've also updated the patch, to have javadocs example usage.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239793#comment-13239793 ]

Dawid Weiss commented on SOLR-3272:
-----------------------------------

I actually don't know what the policy is -- I asked on the dev list, we'll see what solr folks prefer.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239800#comment-13239800 ]

Uwe Schindler commented on SOLR-3272:
-------------------------------------

Hi, the patch has one problem (unrelated to the JAR file problem): It uses toUpperCase() without locale, so uppercasing with e.g. Turkish locale will fail horrible. This type of code must use toUpperCase(Locale.ENGLISH).

It the JAR file already included with analysis module? I don't really understand the problem with the JAR file.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239804#comment-13239804 ]

Uwe Schindler commented on SOLR-3272:
-------------------------------------

Ah I see, the dictionaries are already there. In that case we would not duplicate them inside the Solr tree. It should stay in analysis module. We can move them during build and war-file creation to solr, like we do with other lucene jars.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239805#comment-13239805 ]

Rafał Kuć commented on SOLR-3272:
---------------------------------

I'll update the patch and the build files, thanks for comments.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239811#comment-13239811 ]

Dawid Weiss commented on SOLR-3272:
-----------------------------------

Thanks Uwe. Btw. should we apply it to 3.x as well? This seems like a harmless patch and it'd be a nice-to-have feature.
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239816#comment-13239816 ]

Robert Muir commented on SOLR-3272:
-----------------------------------

There is no morfologik in 3.x. I asked about that before but you seemed a tad offended
at the prospect of a java5 version :)
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239824#comment-13239824 ]

Dawid Weiss commented on SOLR-3272:
-----------------------------------

Damn. [Blushing].

I could prepare a 1.5 compatible version with retroweaver and integrate it in. I guess now I don't have excuses, do I... Do we want to push it in at the last minute though?
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239837#comment-13239837 ]

Robert Muir commented on SOLR-3272:
-----------------------------------

I have no objection, as long as all new files:

* have package.html
* have some javadocs for each class
* have apache license header

and assuming its in by tomorrow (when i will freeze).

Stuff like new analyzers that weren't available before aren't really risky,
because they won't break any existing functionality.

               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafał Kuć updated SOLR-3272:
----------------------------

    Attachment: SOLR-3272-toupper-correction.patch

Corrected toUpper to use Locale.ENGLISH
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-toupper-correction.patch, SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3272) Solr filter factory for MorfologikFilter

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss updated SOLR-3272:
------------------------------

    Attachment: SOLR-3272.patch

I attach a patch that introduces subtle changes (enum.valueOf never returns null, it throws an exception on invalid values).

There is also my take at build integration although I have no idea if I did it right -- where is the code that copies these JARs to solr? The code compiles for me but the war file doesn't have any contribs, for example (they're optional?).
               

> Solr filter factory for MorfologikFilter
> ----------------------------------------
>
>                 Key: SOLR-3272
>                 URL: https://issues.apache.org/jira/browse/SOLR-3272
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Rafał Kuć
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-3272-toupper-correction.patch, SOLR-3272-with-javadoc-example-usage.patch, SOLR-3272.patch, SOLR-3272.patch, SOLR-3727-new.patch
>
>
> I didn't find MorfologikFilter factory in Solr, so here is a simple. Maybe someone will have make use of it :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12