[jira] Created: (SOLR-389) RequestHandlerBase javadocs improvement

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
RequestHandlerBase javadocs improvement
---------------------------------------

                 Key: SOLR-389
                 URL: https://issues.apache.org/jira/browse/SOLR-389
             Project: Solr
          Issue Type: Improvement
          Components: documentation
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Trivial


Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SOLR-389 started by Grant Ingersoll.

> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-389:
---------------------------------

    Attachment: SOLR-389.patch

First draft of javadocs for RequestHandlerBase#init method explaining the use of defaults, invariants and appends parameters.

> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>         Attachments: SOLR-389.patch
>
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-389:
---------------------------------

    Attachment: SOLR-389.patch

Changed @see method to point to SolrPluginUtils instead of U#setDefaults

> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>         Attachments: SOLR-389.patch, SOLR-389.patch
>
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley reassigned SOLR-389:
----------------------------------

    Assignee: Ryan McKinley  (was: Grant Ingersoll)

Thanks Grant

Do you want me to commit this now?  Is it still "In Progress"  (I have not seen people use that status before, does it mean you are still working on it?)

> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Ryan McKinley
>            Priority: Trivial
>         Attachments: SOLR-389.patch, SOLR-389.patch
>
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538368 ]

Ryan McKinley commented on SOLR-389:
------------------------------------

I will delete:
http://wiki.apache.org/solr/RequestHandlerBase

to avoid the duplicate docs

> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Ryan McKinley
>            Priority: Trivial
>         Attachments: SOLR-389.patch, SOLR-389.patch
>
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539864 ]

Grant Ingersoll commented on SOLR-389:
--------------------------------------

It should be done, pending your review.






> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Ryan McKinley
>            Priority: Trivial
>         Attachments: SOLR-389.patch, SOLR-389.patch
>
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-389) RequestHandlerBase javadocs improvement

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-389.
--------------------------------

    Resolution: Fixed

commited a while back.  Thanks Grant

> RequestHandlerBase javadocs improvement
> ---------------------------------------
>
>                 Key: SOLR-389
>                 URL: https://issues.apache.org/jira/browse/SOLR-389
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Grant Ingersoll
>            Assignee: Ryan McKinley
>            Priority: Trivial
>         Attachments: SOLR-389.patch, SOLR-389.patch
>
>
> Provide more javadocs on RequestHandlerBase#.init(NamedList) method to explain about the defaults, appends and invariants

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.