[jira] Created: (SOLR-45) enable thresholded field compression for certain field types

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-45) enable thresholded field compression for certain field types

Steve Loughran (Jira)
enable thresholded field compression for certain field types
-------------------------------------------------------------

                 Key: SOLR-45
                 URL: http://issues.apache.org/jira/browse/SOLR-45
             Project: Solr
          Issue Type: New Feature
          Components: update
            Reporter: Mike Klaas
         Assigned To: Mike Klaas
            Priority: Minor
         Attachments: compress_patch.diff

Adds a CompressableField abstract base class from which fieldtypes may inherit.  Fields of these types may specify compressed="true" in the field definition to turn on compression.  The field type takes an optional compressThreshold parameter which will only turn on compression for fields whose internal representations of greater or equal to a given size.

TextField and StrField inherit from CompressableField

Comments? (my main issue is that it woudl be nice to be able to set compressThreshold at the field level.  Since we can't without modifying fields to accept named parameters, perhaps it would be preferrable to only allow compress=true/false to be set at the fieldtype leve)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-45) enable thresholded field compression for certain field types

Steve Loughran (Jira)
    [ http://issues.apache.org/jira/browse/SOLR-45?page=comments#action_12432925 ]
           
Yonik Seeley commented on SOLR-45:
----------------------------------

Looks good.  I'd leave things as you have them.
I think allowing compressTheshold at the fieldtype level is better than not allowing it at all.

If I could re-do Solr, I think I would try to eliminate fieldtype alltogether and substitute it with field inheritance.



> enable thresholded field compression for certain field types
> ------------------------------------------------------------
>
>                 Key: SOLR-45
>                 URL: http://issues.apache.org/jira/browse/SOLR-45
>             Project: Solr
>          Issue Type: New Feature
>          Components: update
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>         Attachments: compress_patch.diff
>
>
> Adds a CompressableField abstract base class from which fieldtypes may inherit.  Fields of these types may specify compressed="true" in the field definition to turn on compression.  The field type takes an optional compressThreshold parameter which will only turn on compression for fields whose internal representations of greater or equal to a given size.
> TextField and StrField inherit from CompressableField
> Comments? (my main issue is that it woudl be nice to be able to set compressThreshold at the field level.  Since we can't without modifying fields to accept named parameters, perhaps it would be preferrable to only allow compress=true/false to be set at the fieldtype leve)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-45) enable thresholded field compression for certain field types

Steve Loughran (Jira)
In reply to this post by Steve Loughran (Jira)
     [ http://issues.apache.org/jira/browse/SOLR-45?page=all ]

Mike Klaas resolved SOLR-45.
----------------------------

    Resolution: Fixed

Commited slightly modified patch in r440837

> enable thresholded field compression for certain field types
> ------------------------------------------------------------
>
>                 Key: SOLR-45
>                 URL: http://issues.apache.org/jira/browse/SOLR-45
>             Project: Solr
>          Issue Type: New Feature
>          Components: update
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>         Attachments: compress_patch.diff
>
>
> Adds a CompressableField abstract base class from which fieldtypes may inherit.  Fields of these types may specify compressed="true" in the field definition to turn on compression.  The field type takes an optional compressThreshold parameter which will only turn on compression for fields whose internal representations of greater or equal to a given size.
> TextField and StrField inherit from CompressableField
> Comments? (my main issue is that it woudl be nice to be able to set compressThreshold at the field level.  Since we can't without modifying fields to accept named parameters, perhaps it would be preferrable to only allow compress=true/false to be set at the fieldtype leve)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira