[jira] Created: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

Tim Allison (Jira)
CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis
-----------------------------------------------------------------------------------------------

                 Key: SOLR-476
                 URL: https://issues.apache.org/jira/browse/SOLR-476
             Project: Solr
          Issue Type: New Feature
          Components: clients - java
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Minor


http://www.mail-archive.com/solr-user@.../msg08914.html

SolrJ needs a way to pass in the ResponseParser on a per request basis.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Work started: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SOLR-476 started by Grant Ingersoll.

> CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-476
>                 URL: https://issues.apache.org/jira/browse/SOLR-476
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>
> http://www.mail-archive.com/solr-user@.../msg08914.html
> SolrJ needs a way to pass in the ResponseParser on a per request basis.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-476:
---------------------------------

    Attachment: SOLR-476.patch

Adds ResponseParser to SolrRequest, also makes it an optional method on CommonsHttpSolrServer.  

If the SolrRequest defines the ResponseParser, then it is used, otherwise the member variable on CommonsHttpSolrServer is used.

Also added some different construction options to CommonsHttpSolrServer

> CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-476
>                 URL: https://issues.apache.org/jira/browse/SOLR-476
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-476.patch
>
>
> http://www.mail-archive.com/solr-user@.../msg08914.html
> SolrJ needs a way to pass in the ResponseParser on a per request basis.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571432#action_12571432 ]

Ryan McKinley commented on SOLR-476:
------------------------------------

Looks good -- the one thing we should sort out is the invariants params in the case where the ResponseParser comes from the request.  As is, the "wt" and "version" params are set in the constructor.  That should move to the request method.  I suppose we should also add a "getVersion()" method to ResponseParser rather than assume 2.2



> CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-476
>                 URL: https://issues.apache.org/jira/browse/SOLR-476
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-476.patch
>
>
> http://www.mail-archive.com/solr-user@.../msg08914.html
> SolrJ needs a way to pass in the ResponseParser on a per request basis.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-476:
-------------------------------

    Attachment: SOLR-476.patch

updated the patch so that it

1. sets the wt and version based on the parser
2. adds "getVersion()" to RequestParser
3. refactors "_processor" to "_parser"

I think this is good to go -- grant, if this works for you, can you commit it?

> CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-476
>                 URL: https://issues.apache.org/jira/browse/SOLR-476
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-476.patch, SOLR-476.patch
>
>
> http://www.mail-archive.com/solr-user@.../msg08914.html
> SolrJ needs a way to pass in the ResponseParser on a per request basis.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-476) CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-476.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

commited in rev 632228

> CommonsHttpSolrServer should provide a way to pass in the ResponseParser on a per request basis
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-476
>                 URL: https://issues.apache.org/jira/browse/SOLR-476
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-476.patch, SOLR-476.patch
>
>
> http://www.mail-archive.com/solr-user@.../msg08914.html
> SolrJ needs a way to pass in the ResponseParser on a per request basis.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.