[jira] Created: (SOLR-479) Solr Test code coverage

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-479) Solr Test code coverage

Tim Allison (Jira)
Solr Test code coverage
-----------------------

                 Key: SOLR-479
                 URL: https://issues.apache.org/jira/browse/SOLR-479
             Project: Solr
          Issue Type: New Feature
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Minor


The ASF has a donated license of Clover test coverage.  Would be useful to have some ANT targets that calculate test coverage.  See Lucene Java's implementation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-479) Solr Test code coverage

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-479:
---------------------------------

    Attachment: SOLR-479.patch

Slurped Lucene J's clover test coverage handling into Solr's build system.

For a sample of the output, see http://people.apache.org/~gsingers/solr-clover/reports/

Note, you must have the clover.jar and clover license in your ANT lib for this to work.  These are available for any Solr committer but are not available to the general public.

I ran
{code}
ant -Drun.clover=true clean clover test generate-clover-reports
{code}

to generate the link above.  Clover will not be run by default.  It probably would be useful to hook this into the nightly build, but you have to be careful to make sure the instrumented files don't get shipped in the release.  

> Solr Test code coverage
> -----------------------
>
>                 Key: SOLR-479
>                 URL: https://issues.apache.org/jira/browse/SOLR-479
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-479.patch
>
>
> The ASF has a donated license of Clover test coverage.  Would be useful to have some ANT targets that calculate test coverage.  See Lucene Java's implementation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-479) Solr Test code coverage

Tim Allison (Jira)
In reply to this post by Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll resolved SOLR-479.
----------------------------------

    Resolution: Fixed

Committed revision 629340.

> Solr Test code coverage
> -----------------------
>
>                 Key: SOLR-479
>                 URL: https://issues.apache.org/jira/browse/SOLR-479
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-479.patch
>
>
> The ASF has a donated license of Clover test coverage.  Would be useful to have some ANT targets that calculate test coverage.  See Lucene Java's implementation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Resolved: (SOLR-479) Solr Test code coverage

hossman

Grant: thanks for cranking this out ... do you know what needs to be done
to have Hudson run this (and link to it) automaticly?  do we need Nigel's
help with that, or is it something we can do ourselves?

(and by we, i think i mean "you" ... does anyone else involve with
Solr/Lucene have access tothe hudson configuration stuff at this point?)

-Hoss

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Resolved: (SOLR-479) Solr Test code coverage

Grant Ingersoll-2
If we hook it into the "nightly" target, then the only thing that  
needs to be done is make sure Hudson captures the reports.  The trick  
in hooking it into the nightly is that you want to make sure you clean  
before doing any other packaging to make sure that the instrumented  
files are not in the build.

If someone takes care of that, I can see to it that it gets in  
Hudson.  Also, I'd be more than happy to get another Solr committer  
setup on Hudson.  It is really easy to work with, especially the newer  
version.

Volunteers?

-Grant


On Feb 21, 2008, at 6:18 PM, Chris Hostetter wrote:

>
> Grant: thanks for cranking this out ... do you know what needs to be  
> done
> to have Hudson run this (and link to it) automaticly?  do we need  
> Nigel's
> help with that, or is it something we can do ourselves?
>
> (and by we, i think i mean "you" ... does anyone else involve with
> Solr/Lucene have access tothe hudson configuration stuff at this  
> point?)
>
> -Hoss
>


Reply | Threaded
Open this post in threaded view
|

Re: [jira] Resolved: (SOLR-479) Solr Test code coverage

hossman
: If we hook it into the "nightly" target, then the only thing that needs to be
: done is make sure Hudson captures the reports.  The trick in hooking it into
: the nightly is that you want to make sure you clean before doing any other
: packaging to make sure that the instrumented files are not in the build.

i'm pretty sure the hudson artifacts aren't the ones we distribute as the
"nightly build" .. that's still done by a cron in the lucene zone AFAIK,
so it shouldn't be a big deal.

honestly: i'm starting to come around to the idea that we should stop
distributing nightly builds at all -- just ue hudson for automated
unit/coverage tests and shut off the cron scripts ... but that's a topic
for a seperate thread.

: If someone takes care of that, I can see to it that it gets in Hudson.  Also,
: I'd be more than happy to get another Solr committer setup on Hudson.  It is
: really easy to work with, especially the newer version.

go ahead and set me up with a hudson account and i'll take a look at it --
there are some aspects of clover that i don't get yet, so i'd like to make
sure i understand what's going wrong with the lucene-java clover setup
first.




-Hoss

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Resolved: (SOLR-479) Solr Test code coverage

Nigel Daley

On Feb 24, 2008, at 11:48 PM, Chris Hostetter wrote:

> : If we hook it into the "nightly" target, then the only thing that  
> needs to be
> : done is make sure Hudson captures the reports.  The trick in  
> hooking it into
> : the nightly is that you want to make sure you clean before doing  
> any other
> : packaging to make sure that the instrumented files are not in the  
> build.
>
> i'm pretty sure the hudson artifacts aren't the ones we distribute  
> as the
> "nightly build" .. that's still done by a cron in the lucene zone  
> AFAIK,
> so it shouldn't be a big deal.
>
> honestly: i'm starting to come around to the idea that we should stop
> distributing nightly builds at all -- just ue hudson for automated
> unit/coverage tests and shut off the cron scripts ... but that's a  
> topic
> for a seperate thread.
>
> : If someone takes care of that, I can see to it that it gets in  
> Hudson.  Also,
> : I'd be more than happy to get another Solr committer setup on  
> Hudson.  It is
> : really easy to work with, especially the newer version.
>
> go ahead and set me up with a hudson account and i'll take a look  
> at it --
> there are some aspects of clover that i don't get yet, so i'd like  
> to make
> sure i understand what's going wrong with the lucene-java clover setup
> first.

Hoss, follow the directions here (first question in FAQ):
http://wiki.apache.org/general/Hudson
to get an account on hudson.zones.apache.org

Thx,
Nige