[jira] Created: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Hudson (Jira)
need a way for tests to specify arbitrary solrconfig.xml files
--------------------------------------------------------------

         Key: SOLR-8
         URL: http://issues.apache.org/jira/browse/SOLR-8
     Project: Solr
        Type: Sub-task

    Reporter: Hoss Man
 Assigned to: Hoss Man
    Priority: Minor


currently, there is no mechanism to use more then one solrconfig.xml in a JVM.  this makes writing tests of incompatible config options impossible, so we should make whatever changes are neccessary so that TestHarness can be given a config file name inthe same way it takes a schema file name.
 

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Hudson (Jira)
     [ http://issues.apache.org/jira/browse/SOLR-8?page=all ]

Hoss Man updated SOLR-8:
------------------------

    Attachment: SOLR-8.patch

patch includes a static initConfig method in SolrConfig so that tests can re-init the config using whatever fiel they want.

(I don't consider this a perfect solution, but it's the simplest one given that SolrConfig is a singleton -- trying to change that would be scary)

patch also includes:
 * changes to TestHarness, AbstractSolrTestCase, and all of the existing test class to utilize this
 * new copies of the configs previously used from the apps/SolrTest directory
 * build.xml change so the CWD for the junit tests is a new test-files directory

with this patch, all conections between the junit tests and the legacy SolrTest code/directory are severed.


if no one objects, i'll commit this in a day or two.

> need a way for tests to specify arbitrary solrconfig.xml files
> --------------------------------------------------------------
>
>          Key: SOLR-8
>          URL: http://issues.apache.org/jira/browse/SOLR-8
>      Project: Solr
>         Type: Sub-task

>     Reporter: Hoss Man
>     Assignee: Hoss Man
>     Priority: Minor
>  Attachments: SOLR-8.patch
>
> currently, there is no mechanism to use more then one solrconfig.xml in a JVM.  this makes writing tests of incompatible config options impossible, so we should make whatever changes are neccessary so that TestHarness can be given a config file name inthe same way it takes a schema file name.
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Hudson (Jira)
In reply to this post by Hudson (Jira)
    [ http://issues.apache.org/jira/browse/SOLR-8?page=comments#action_12374969 ]

Yonik Seeley commented on SOLR-8:
---------------------------------

+1

It should only be used for testing though... (it's not thread-safe, among other issues having to do with how it's used...)

> need a way for tests to specify arbitrary solrconfig.xml files
> --------------------------------------------------------------
>
>          Key: SOLR-8
>          URL: http://issues.apache.org/jira/browse/SOLR-8
>      Project: Solr
>         Type: Sub-task

>     Reporter: Hoss Man
>     Assignee: Hoss Man
>     Priority: Minor
>  Attachments: SOLR-8.patch
>
> currently, there is no mechanism to use more then one solrconfig.xml in a JVM.  this makes writing tests of incompatible config options impossible, so we should make whatever changes are neccessary so that TestHarness can be given a config file name inthe same way it takes a schema file name.
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Hudson (Jira)
In reply to this post by Hudson (Jira)
    [ http://issues.apache.org/jira/browse/SOLR-8?page=comments#action_12374973 ]

Hoss Man commented on SOLR-8:
-----------------------------

> It should only be used for testing though

agreed, I was going to add a big fat warning about that, but I figured it would be obvious since the Config object is a singleton ... but i'll add it anyway.

> need a way for tests to specify arbitrary solrconfig.xml files
> --------------------------------------------------------------
>
>          Key: SOLR-8
>          URL: http://issues.apache.org/jira/browse/SOLR-8
>      Project: Solr
>         Type: Sub-task

>     Reporter: Hoss Man
>     Assignee: Hoss Man
>     Priority: Minor
>  Attachments: SOLR-8.patch
>
> currently, there is no mechanism to use more then one solrconfig.xml in a JVM.  this makes writing tests of incompatible config options impossible, so we should make whatever changes are neccessary so that TestHarness can be given a config file name inthe same way it takes a schema file name.
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Hudson (Jira)
In reply to this post by Hudson (Jira)
     [ http://issues.apache.org/jira/browse/SOLR-8?page=all ]
     
Hoss Man resolved SOLR-8:
-------------------------

    Resolution: Fixed

patch commited with added warning about initConfig

> need a way for tests to specify arbitrary solrconfig.xml files
> --------------------------------------------------------------
>
>          Key: SOLR-8
>          URL: http://issues.apache.org/jira/browse/SOLR-8
>      Project: Solr
>         Type: Sub-task

>     Reporter: Hoss Man
>     Assignee: Hoss Man
>     Priority: Minor
>  Attachments: SOLR-8.patch
>
> currently, there is no mechanism to use more then one solrconfig.xml in a JVM.  this makes writing tests of incompatible config options impossible, so we should make whatever changes are neccessary so that TestHarness can be given a config file name inthe same way it takes a schema file name.
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (SOLR-8) need a way for tests to specify arbitrary solrconfig.xml files

Hudson (Jira)
In reply to this post by Hudson (Jira)
     [ http://issues.apache.org/jira/browse/SOLR-8?page=all ]
     
Hoss Man closed SOLR-8:
-----------------------


> need a way for tests to specify arbitrary solrconfig.xml files
> --------------------------------------------------------------
>
>          Key: SOLR-8
>          URL: http://issues.apache.org/jira/browse/SOLR-8
>      Project: Solr
>         Type: Sub-task

>     Reporter: Hoss Man
>     Assignee: Hoss Man
>     Priority: Minor
>  Attachments: SOLR-8.patch
>
> currently, there is no mechanism to use more then one solrconfig.xml in a JVM.  this makes writing tests of incompatible config options impossible, so we should make whatever changes are neccessary so that TestHarness can be given a config file name inthe same way it takes a schema file name.
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira