[jira] Created: (TIKA-42) Content class needs (String,String,String) constructor.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (TIKA-42) Content class needs (String,String,String) constructor.

David Eric Pugh (Jira)
Content class needs (String,String,String) constructor.
-------------------------------------------------------

                 Key: TIKA-42
                 URL: https://issues.apache.org/jira/browse/TIKA-42
             Project: Tika
          Issue Type: Improvement
          Components: general
    Affects Versions: 0.1-incubator
            Reporter: Keith R. Bennett
             Fix For: 0.1-incubator


Since Iterable<Content> is now a parameter of the public Parser interface, it is important to minimize the amount of effort required to create this parameter.  Currently, if one knows the strings (text, xpath, and regex), it is necessary to create a JDOM element to store those strings, and one must inspect the source code to see how they are stored (attribute vs. element, for example).


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (TIKA-42) Content class needs (String,String,String) constructor.

David Eric Pugh (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith R. Bennett updated TIKA-42:
---------------------------------

    Attachment: tika42.patch

The attached patch adds the (String,String,String) constructor to Content.

+    public Content(String xPathSelect, String textSelect, String regexSelect) {
+        this.xPathSelect = xPathSelect;
+        this.textSelect = textSelect;
+        this.regexSelect = regexSelect;
+    }

> Content class needs (String,String,String) constructor.
> -------------------------------------------------------
>
>                 Key: TIKA-42
>                 URL: https://issues.apache.org/jira/browse/TIKA-42
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>             Fix For: 0.1-incubator
>
>         Attachments: tika42.patch
>
>
> Since Iterable<Content> is now a parameter of the public Parser interface, it is important to minimize the amount of effort required to create this parameter.  Currently, if one knows the strings (text, xpath, and regex), it is necessary to create a JDOM element to store those strings, and one must inspect the source code to see how they are stored (attribute vs. element, for example).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (TIKA-42) Content class needs (String,String,String) constructor.

David Eric Pugh (Jira)
In reply to this post by David Eric Pugh (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved TIKA-42.
-------------------------------

    Resolution: Fixed
      Assignee: Jukka Zitting

Patch committed in revision 582139.

I believe we should rethink or replace the whole Content class, but for now this improvement makes sense.

> Content class needs (String,String,String) constructor.
> -------------------------------------------------------
>
>                 Key: TIKA-42
>                 URL: https://issues.apache.org/jira/browse/TIKA-42
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Assignee: Jukka Zitting
>             Fix For: 0.1-incubator
>
>         Attachments: tika42.patch
>
>
> Since Iterable<Content> is now a parameter of the public Parser interface, it is important to minimize the amount of effort required to create this parameter.  Currently, if one knows the strings (text, xpath, and regex), it is necessary to create a JDOM element to store those strings, and one must inspect the source code to see how they are stored (attribute vs. element, for example).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.