[jira] Created: (TIKA-47) Remove TikaLogger

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (TIKA-47) Remove TikaLogger

Jorge Spinsanti (Jira)
Remove TikaLogger
-----------------

                 Key: TIKA-47
                 URL: https://issues.apache.org/jira/browse/TIKA-47
             Project: Tika
          Issue Type: Improvement
            Reporter: Jukka Zitting
            Priority: Minor


The org.apache.tika.log.TikaLogger class is essentially a simple wrapper for Log4J PropertyConfigurator.

We should remove the class and directly configure Log4J (or whatever logging framework we use) in client code.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (TIKA-47) Remove TikaLogger

Jorge Spinsanti (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann reassigned TIKA-47:
-------------------------------------

    Assignee: Chris A. Mattmann

> Remove TikaLogger
> -----------------
>
>                 Key: TIKA-47
>                 URL: https://issues.apache.org/jira/browse/TIKA-47
>             Project: Tika
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>
> The org.apache.tika.log.TikaLogger class is essentially a simple wrapper for Log4J PropertyConfigurator.
> We should remove the class and directly configure Log4J (or whatever logging framework we use) in client code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (TIKA-47) Remove TikaLogger

Jorge Spinsanti (Jira)
In reply to this post by Jorge Spinsanti (Jira)

    [ https://issues.apache.org/jira/browse/TIKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532992 ]

Chris A. Mattmann commented on TIKA-47:
---------------------------------------

+1 here.

Question for you: should we remove the use of Log4J in general as part of this issue and move to JDK logging? So far, Jukka and I are both +1 for JDK logging. Is this acceptable to everyone else? If so, I'd like to propose removing all logging dependencies and changing all logging in Tika to use JDK 1.4 logging, configured with a tika.logging.properties file. What do others think?

> Remove TikaLogger
> -----------------
>
>                 Key: TIKA-47
>                 URL: https://issues.apache.org/jira/browse/TIKA-47
>             Project: Tika
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Priority: Minor
>
> The org.apache.tika.log.TikaLogger class is essentially a simple wrapper for Log4J PropertyConfigurator.
> We should remove the class and directly configure Log4J (or whatever logging framework we use) in client code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (TIKA-47) Remove TikaLogger

Jorge Spinsanti (Jira)
In reply to this post by Jorge Spinsanti (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated TIKA-47:
------------------------------

    Attachment: TIKA-47.patch

Here's a patch that removes the TikaLogger class and moves the current log4j configuration to src/test/resources and invokes it using the log4j.configuration system property instead of code within TestParsers.

As for switching to JDK logging, I think we can do it (unless anyone objects) but let's have a separate issue for that.

> Remove TikaLogger
> -----------------
>
>                 Key: TIKA-47
>                 URL: https://issues.apache.org/jira/browse/TIKA-47
>             Project: Tika
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>         Attachments: TIKA-47.patch
>
>
> The org.apache.tika.log.TikaLogger class is essentially a simple wrapper for Log4J PropertyConfigurator.
> We should remove the class and directly configure Log4J (or whatever logging framework we use) in client code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (TIKA-47) Remove TikaLogger

Jorge Spinsanti (Jira)
In reply to this post by Jorge Spinsanti (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved TIKA-47.
-------------------------------

    Resolution: Fixed
      Assignee: Jukka Zitting  (was: Chris A. Mattmann)

In fact I just went ahead and committed this change in revision 582668.

> Remove TikaLogger
> -----------------
>
>                 Key: TIKA-47
>                 URL: https://issues.apache.org/jira/browse/TIKA-47
>             Project: Tika
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: TIKA-47.patch
>
>
> The org.apache.tika.log.TikaLogger class is essentially a simple wrapper for Log4J PropertyConfigurator.
> We should remove the class and directly configure Log4J (or whatever logging framework we use) in client code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (TIKA-47) Remove TikaLogger

Jorge Spinsanti (Jira)
In reply to this post by Jorge Spinsanti (Jira)

    [ https://issues.apache.org/jira/browse/TIKA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532996 ]

Chris A. Mattmann commented on TIKA-47:
---------------------------------------

+1, no probs

> Remove TikaLogger
> -----------------
>
>                 Key: TIKA-47
>                 URL: https://issues.apache.org/jira/browse/TIKA-47
>             Project: Tika
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: TIKA-47.patch
>
>
> The org.apache.tika.log.TikaLogger class is essentially a simple wrapper for Log4J PropertyConfigurator.
> We should remove the class and directly configure Log4J (or whatever logging framework we use) in client code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.