[jira] Created: (TIKA-55) ParseUtils.getParser() method variants should have consistent parameter orders.

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (TIKA-55) ParseUtils.getParser() method variants should have consistent parameter orders.

David Eric Pugh (Jira)
ParseUtils.getParser() method variants should have consistent parameter orders.
-------------------------------------------------------------------------------

                 Key: TIKA-55
                 URL: https://issues.apache.org/jira/browse/TIKA-55
             Project: Tika
          Issue Type: Improvement
          Components: general
    Affects Versions: 0.1-incubator
            Reporter: Keith R. Bennett
            Priority: Minor
             Fix For: 0.1-incubator


There are the following getParser() methods in ParseUtils:

    public static Parser getParser(TikaConfig config, String mimeType)
    public static Parser getParser(URL documentUrl, TikaConfig config)
    public static Parser getParser(File documentFile, TikaConfig config)

The TikaConfig argument should be the same argument number in all of them.  I suggest reversing the parameters in the first one in the list.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (TIKA-55) ParseUtils.getParser() method variants should have consistent parameter orders.

David Eric Pugh (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith R. Bennett updated TIKA-55:
---------------------------------

    Attachment: tika55.patch

Attached is the patch to resolve this issue.  Only the ParseUtils class is affected.


> ParseUtils.getParser() method variants should have consistent parameter orders.
> -------------------------------------------------------------------------------
>
>                 Key: TIKA-55
>                 URL: https://issues.apache.org/jira/browse/TIKA-55
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>         Attachments: tika55.patch
>
>
> There are the following getParser() methods in ParseUtils:
>     public static Parser getParser(TikaConfig config, String mimeType)
>     public static Parser getParser(URL documentUrl, TikaConfig config)
>     public static Parser getParser(File documentFile, TikaConfig config)
> The TikaConfig argument should be the same argument number in all of them.  I suggest reversing the parameters in the first one in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (TIKA-55) ParseUtils.getParser() method variants should have consistent parameter orders.

David Eric Pugh (Jira)
In reply to this post by David Eric Pugh (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann reassigned TIKA-55:
-------------------------------------

    Assignee: Chris A. Mattmann

> ParseUtils.getParser() method variants should have consistent parameter orders.
> -------------------------------------------------------------------------------
>
>                 Key: TIKA-55
>                 URL: https://issues.apache.org/jira/browse/TIKA-55
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>         Attachments: tika55.patch
>
>
> There are the following getParser() methods in ParseUtils:
>     public static Parser getParser(TikaConfig config, String mimeType)
>     public static Parser getParser(URL documentUrl, TikaConfig config)
>     public static Parser getParser(File documentFile, TikaConfig config)
> The TikaConfig argument should be the same argument number in all of them.  I suggest reversing the parameters in the first one in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (TIKA-55) ParseUtils.getParser() method variants should have consistent parameter orders.

David Eric Pugh (Jira)
In reply to this post by David Eric Pugh (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann resolved TIKA-55.
-----------------------------------

    Resolution: Fixed

- patch applied with no changes. Thanks, Keith!

> ParseUtils.getParser() method variants should have consistent parameter orders.
> -------------------------------------------------------------------------------
>
>                 Key: TIKA-55
>                 URL: https://issues.apache.org/jira/browse/TIKA-55
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>         Attachments: tika55.patch
>
>
> There are the following getParser() methods in ParseUtils:
>     public static Parser getParser(TikaConfig config, String mimeType)
>     public static Parser getParser(URL documentUrl, TikaConfig config)
>     public static Parser getParser(File documentFile, TikaConfig config)
> The TikaConfig argument should be the same argument number in all of them.  I suggest reversing the parameters in the first one in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (TIKA-55) ParseUtils.getParser() method variants should have consistent parameter orders.

David Eric Pugh (Jira)
In reply to this post by David Eric Pugh (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann closed TIKA-55.
---------------------------------


- fixed in r583970.

> ParseUtils.getParser() method variants should have consistent parameter orders.
> -------------------------------------------------------------------------------
>
>                 Key: TIKA-55
>                 URL: https://issues.apache.org/jira/browse/TIKA-55
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>         Attachments: tika55.patch
>
>
> There are the following getParser() methods in ParseUtils:
>     public static Parser getParser(TikaConfig config, String mimeType)
>     public static Parser getParser(URL documentUrl, TikaConfig config)
>     public static Parser getParser(File documentFile, TikaConfig config)
> The TikaConfig argument should be the same argument number in all of them.  I suggest reversing the parameters in the first one in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.