[jira] Created: (TIKA-60) Use consistent capitalization for Microsoft abbreviation in class names.

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (TIKA-60) Use consistent capitalization for Microsoft abbreviation in class names.

ASF GitHub Bot (Jira)
Use consistent capitalization for Microsoft abbreviation in class names.
------------------------------------------------------------------------

                 Key: TIKA-60
                 URL: https://issues.apache.org/jira/browse/TIKA-60
             Project: Tika
          Issue Type: Improvement
          Components: general
    Affects Versions: 0.1-incubator
            Reporter: Keith R. Bennett
            Priority: Minor
             Fix For: 0.1-incubator


We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:

org/apache/tika/metadata/MSOffice.java
org/apache/tika/parser/ms/MSParser.java
org/apache/tika/parser/msexcel/MsExcelParser.java
org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
org/apache/tika/parser/msword/MsWordParser.java


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (TIKA-60) Use consistent capitalization for Microsoft abbreviation in class names.

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/TIKA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534483 ]

Bertrand Delacretaz commented on TIKA-60:
-----------------------------------------

+1 for MS

> Use consistent capitalization for Microsoft abbreviation in class names.
> ------------------------------------------------------------------------
>
>                 Key: TIKA-60
>                 URL: https://issues.apache.org/jira/browse/TIKA-60
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:
> org/apache/tika/metadata/MSOffice.java
> org/apache/tika/parser/ms/MSParser.java
> org/apache/tika/parser/msexcel/MsExcelParser.java
> org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
> org/apache/tika/parser/msword/MsWordParser.java

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (TIKA-60) Use consistent capitalization for Microsoft abbreviation in class names.

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/TIKA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534489 ]

Jukka Zitting commented on TIKA-60:
-----------------------------------

How about just dropping the MS prefix at least from the parser classes? Excel, PowerPoint, and Word are quite descriptive even without the MS prefix.

Also, about the package naming, IMHO we should spell out the ms package as microsoft and place all the related parser classes in that package to reduce the number of small packages we currently have.

Something like:

    org/apache/tika/parser/microsoft/OfficeParser.java (the base class)
    org/apache/tika/parser/microsoft/ExcelParser.java
    org/apache/tika/parser/microsoft/PowerPointParser.java
    org/apache/tika/parser/microsoft/WordParser.java


> Use consistent capitalization for Microsoft abbreviation in class names.
> ------------------------------------------------------------------------
>
>                 Key: TIKA-60
>                 URL: https://issues.apache.org/jira/browse/TIKA-60
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:
> org/apache/tika/metadata/MSOffice.java
> org/apache/tika/parser/ms/MSParser.java
> org/apache/tika/parser/msexcel/MsExcelParser.java
> org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
> org/apache/tika/parser/msword/MsWordParser.java

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (TIKA-60) Use consistent capitalization for Microsoft abbreviation in class names.

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/TIKA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534506 ]

Bertrand Delacretaz commented on TIKA-60:
-----------------------------------------

Jukka, you're right about the prefix being useless, I agree with your suggested package names

> Use consistent capitalization for Microsoft abbreviation in class names.
> ------------------------------------------------------------------------
>
>                 Key: TIKA-60
>                 URL: https://issues.apache.org/jira/browse/TIKA-60
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:
> org/apache/tika/metadata/MSOffice.java
> org/apache/tika/parser/ms/MSParser.java
> org/apache/tika/parser/msexcel/MsExcelParser.java
> org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
> org/apache/tika/parser/msword/MsWordParser.java

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (TIKA-60) Use consistent capitalization for Microsoft abbreviation in class names.

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/TIKA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534530 ]

Keith R. Bennett commented on TIKA-60:
--------------------------------------

+1 for Jukka's naming approach.    - Keith


> Use consistent capitalization for Microsoft abbreviation in class names.
> ------------------------------------------------------------------------
>
>                 Key: TIKA-60
>                 URL: https://issues.apache.org/jira/browse/TIKA-60
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:
> org/apache/tika/metadata/MSOffice.java
> org/apache/tika/parser/ms/MSParser.java
> org/apache/tika/parser/msexcel/MsExcelParser.java
> org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
> org/apache/tika/parser/msword/MsWordParser.java

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (TIKA-60) Rename Microsoft parser classes

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated TIKA-60:
------------------------------

       Assignee: Jukka Zitting
    Description:
We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:

org/apache/tika/metadata/MSOffice.java
org/apache/tika/parser/ms/MSParser.java
org/apache/tika/parser/msexcel/MsExcelParser.java
org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
org/apache/tika/parser/msword/MsWordParser.java

  was:
We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:

org/apache/tika/metadata/MSOffice.java
org/apache/tika/parser/ms/MSParser.java
org/apache/tika/parser/msexcel/MsExcelParser.java
org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
org/apache/tika/parser/msword/MsWordParser.java


        Summary: Rename Microsoft parser classes  (was: Use consistent capitalization for Microsoft abbreviation in class names.)

> Rename Microsoft parser classes
> -------------------------------
>
>                 Key: TIKA-60
>                 URL: https://issues.apache.org/jira/browse/TIKA-60
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:
> org/apache/tika/metadata/MSOffice.java
> org/apache/tika/parser/ms/MSParser.java
> org/apache/tika/parser/msexcel/MsExcelParser.java
> org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
> org/apache/tika/parser/msword/MsWordParser.java

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (TIKA-60) Rename Microsoft parser classes

ASF GitHub Bot (Jira)
In reply to this post by ASF GitHub Bot (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved TIKA-60.
-------------------------------

    Resolution: Fixed

Renamed the Microsoft parser classes as proposed in revisions 584532 and  584533.

> Rename Microsoft parser classes
> -------------------------------
>
>                 Key: TIKA-60
>                 URL: https://issues.apache.org/jira/browse/TIKA-60
>             Project: Tika
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.1-incubator
>            Reporter: Keith R. Bennett
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 0.1-incubator
>
>
> We have several classes whose names contain "Ms" or "MS" as abbreviations for Microsoft.  We should be consistent about which one we use.  (My personal preference is "MS".)  Here is a list of the classes:
> org/apache/tika/metadata/MSOffice.java
> org/apache/tika/parser/ms/MSParser.java
> org/apache/tika/parser/msexcel/MsExcelParser.java
> org/apache/tika/parser/mspowerpoint/MsPowerPointParser.java
> org/apache/tika/parser/msword/MsWordParser.java

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.