[jira] [Resolved] (HADOOP-3353) DataNode.run() join() and shutdown() ought to have synchronized access to dataNodeThread

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (HADOOP-3353) DataNode.run() join() and shutdown() ought to have synchronized access to dataNodeThread

Tim Allison (Jira)

     [ https://issues.apache.org/jira/browse/HADOOP-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andras Bokor resolved HADOOP-3353.
----------------------------------
    Resolution: Invalid

This code has totally changed in the past 11 years.

> DataNode.run() join()  and shutdown() ought to have  synchronized access to dataNodeThread
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3353
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3353
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Steve Loughran
>            Priority: Major
>
> Looking at the DataNode.run() and join() methods, they are manipulating the state of the dataNodeThread:
>  void join() {
>     if (dataNodeThread != null) {
>       try {
>         dataNodeThread.join();
>       } catch (InterruptedException e) {}
>     }
>   }
> There's something similar in shutdown()
> This could lead to race conditions on shutdown, where the check passes and then the reference is null when the next method is invoked.
> Marking major as race conditions are always trouble, and hard to test.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]