[jira] [Resolved] (SOLR-4817) Solr should not fall back to the back compat built in solr.xml in SolrCloud mode.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SOLR-4817) Solr should not fall back to the back compat built in solr.xml in SolrCloud mode.

Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson resolved SOLR-4817.
----------------------------------

    Resolution: Fixed

I suspect that most of the default solr.xml was actually used by tests, and often not by intention...

So the code checked in for 4x is slightly different than the patch for 5 in that it puts back the default solr.xml and includes an explicit test for constructing the default since the point of the other changes is to remove the dependency on the hard-coded solr.xml.

So going forward, when people write tests they'll have to either
1> reference a solrhome that contains a solr.xml file
or
2> copy the solr.xml file to "the right place". There are several methods in SolrTestCaseJ4 to help here:
copyMinConf - copies a very tiny schema and config file. Does NOT copy solr.xml
copyMinFullSetup - as copyMinConf but DOES copy solr.xml
copySolrHomeToTemp - copies a robust schema and config and solr.xml to a temp dir.
               

> Solr should not fall back to the back compat built in solr.xml in SolrCloud mode.
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4817
>                 URL: https://issues.apache.org/jira/browse/SOLR-4817
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch
>
>
> A hard error is much more useful, and this built in solr.xml is not very good for solrcloud - with the old style solr.xml with cores in it, you won't have persistence and with the new style, it's not really ideal either.
> I think it makes it easier to debug solr.home to fail on this instead - but just in solrcloud mode for now due to back compat. We might want to pull the whole internal solr.xml for 5.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]