[jira] [Resolved] (TIKA-3207) Invalid language code in TesseractOCRConfig

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (TIKA-3207) Invalid language code in TesseractOCRConfig

Nicholas DiPiazza (Jira)

     [ https://issues.apache.org/jira/browse/TIKA-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Allison resolved TIKA-3207.
-------------------------------
    Fix Version/s: 1.25
         Assignee: Tim Allison
       Resolution: Fixed

Thank you for opening this.  The reason we do this is to defend against command injections.  We could make the regex much more general [-_\+A-Za-z0-9]+ and achieve the same goal.

> Invalid language code in TesseractOCRConfig
> -------------------------------------------
>
>                 Key: TIKA-3207
>                 URL: https://issues.apache.org/jira/browse/TIKA-3207
>             Project: Tika
>          Issue Type: Bug
>          Components: ocr
>    Affects Versions: 1.24.1
>            Reporter: Daniel Smyda
>            Assignee: Tim Allison
>            Priority: Minor
>             Fix For: 1.25
>
>         Attachments: tesseract_exe.PNG
>
>
> Some language packs available on Tesseract's [github|https://github.com/tesseract-ocr/tessdata] support vertical orientations of Chinese (chi_sim_vert and chi_tra_vert). Trying to specify them via TesseractOCRConfig.setLanguage(String language) results in an exception because the regex is not expecting another underscore in the name.
> {code:java}
>     /**
>      * Set tesseract language dictionary to be used. Default is "eng".    
>      * Multiple languages may be specified, separated by plus characters.    
>      * e.g. "chi_tra+chi_sim"
>      */
>     public void setLanguage(String language) {
>         if (!language.matches("([a-zA-Z]{3}(_[a-zA-Z]{3,4})?(\\+?))+")
>                 || language.endsWith("+")) {
>             throw new IllegalArgumentException("Invalid language code");
>         }
>         this.language = language;
>     }
> {code}
> What is the reason behind validating language options?
> Either way, I'd be more than happy to supply a patch. Thank you.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)