[jira] [Updated] (SOLR-4817) Solr should not fall back to the back compat built in solr.xml in SolrCloud mode.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-4817) Solr should not fall back to the back compat built in solr.xml in SolrCloud mode.

Mihir Sharma (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson updated SOLR-4817:
---------------------------------

    Attachment: SOLR-4817.patch

Final version I think. I'll probably be checking this in this evening. I tried applying it directly to 4x and it works fine, which is not surprising since I changed all the tests to NOT use the default configuration.

So I'll add another test in to the 4x version to insure we create the default solr.xml when we should after I merge. It turns out that there are only a few small changes to the patch needed for 4x, the aforementioned test and putting the hard-coded bit back in and reverting removing the string from SolrConfigXmlOld.java

               

> Solr should not fall back to the back compat built in solr.xml in SolrCloud mode.
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4817
>                 URL: https://issues.apache.org/jira/browse/SOLR-4817
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch, SOLR-4817.patch
>
>
> A hard error is much more useful, and this built in solr.xml is not very good for solrcloud - with the old style solr.xml with cores in it, you won't have persistence and with the new style, it's not really ideal either.
> I think it makes it easier to debug solr.home to fail on this instead - but just in solrcloud mode for now due to back compat. We might want to pull the whole internal solr.xml for 5.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]