[lucy-dev] [GitHub] lucy pull request #55: Remove Compiler ivars

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[lucy-dev] [GitHub] lucy pull request #55: Remove Compiler ivars

GitHub user nwellnhof opened a pull request:


    Remove Compiler ivars

    Remove all instance variables from the Compiler base class.
    - Make Compiler inherit from Obj instead of Query.
    - Use per-subclass ivar for boost if needed.
    - Copy some relevant ivars from the respective Query.
    - Fetch Similarity from DataReader's schema.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nwellnhof/lucy compiler-ivars

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
commit 93534fa5bbefc2d38f7f6eb76683975af8186139
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-03-20T15:59:42Z

    Remove 'compiler' ivar from TermMatcher
    TermMatcher only needs the compiler's weight.

commit 19fa8371439b75fbec5eb0a62de53f98064ba045
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-03-20T16:06:09Z

    Remove 'similarity' param from PList_Make_Matcher
    The Similarity can be retrieved from the PListReader's schema.

commit ada2681213b7ebbc0e0a7d17ed002a7a777f6fbf
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-03-20T14:59:12Z

    Remove more args from {Post|PList}_Make_Matcher
    Remove 'sim' and 'need_score' from Post_Make_Matcher. Remove
    'need_score' from PList_Make_Matcher.
    Also move 'sim' ivar from TermMatcher to ScorePostingMatcher.

commit 5f1cdc99a6a49387efbeff11d76f2cfdbe20d27d
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-03-20T15:06:49Z

    Remove Compiler ivars
    Also make Compiler inherit directly from Obj instead of Query. This
    requires separate Equals and serialization methods for all Compilers.
    Add 'sim' parameter to Compiler_Normalize.
    Remove Highlighter_Get_Query.
    Keep the Perl API backward compatible.

commit 104cdc429fe7dfc3c503dc9b82867707b6ba3eae
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-03-24T10:52:01Z

    Implement Make_Root_Compiler
    Make_Root_Compiler calls Make_Compiler and normalizes the returned
    Compiler. It's equivalent to calling Make_Compiler with 'subordinate'
    set to false.
    Remove 'subordinate' param from Make_Compiler, but keep it in the Perl
    API for backward compatibility. CFC doesn't support custom callbacks,
    so alias 'make_compiler' to 'Make_Compiler_Compat'.

commit 6125e8312f73ed7016f4b90f770fc838ccb0bb3b
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-02-13T17:03:29Z

    Compiler serialization tests

commit 7e7972804f8a6610d25bee7a523eb60720be20de
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-03-21T11:42:55Z

    Port Filter and 800-stack.t to new Compiler API

commit b0aad8cbb45c965f701bbe0a7cb1b13f974d1853
Author: Nick Wellnhofer <[hidden email]>
Date:   2017-04-16T11:54:52Z

    Add test for old query/compiler API


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.